Subject: Re: [PATCH v1] wifi: ath9k: fix AR9003 mac hardware hang check register offset calculation

From: Kalle Valo <[email-masked]>
Date: Tue, 25 Apr 2023 08:50:08 +0300

Toke Høiland-Jørgensen <[email-masked]> writes:

> Simon Horman <[email-masked]> writes:
>
>>> -	for (i = 0; i < NUM_STATUS_READS; i++) {
>>> -		if (queue < 6)
>>> -			dma_dbg_chain = REG_READ(ah, AR_DMADBG_4);
>>> -		else
>>> -			dma_dbg_chain = REG_READ(ah, AR_DMADBG_5);
>>> +	if (queue < 6) {
>>> +		dbg_reg = AR_DMADBG_4;
>>> +		reg_offset = i * 5;
>>
>> Hi Peter,
>>
>> unless my eyes are deceiving me, i is not initialised here.
>
> Nice catch! Hmm, I wonder why my test compile didn't complain about
> that? Or maybe it did and I overlooked it? Anyway, Kalle, I already
> delegated this patch to you in patchwork, so please drop it 

Ok, will drop.

> and I'll try to do better on reviewing the next one :)

No worries, reviewing is hard and things always slip past. But great
that we now have more people reviewing, thanks Simon for catching this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches