Subject: Re: [PATCH net v2] l2tp: Serialize access to sk_user_data with sock lock

From: Jakub Sitnicki <[email-masked]>
Date: Wed, 17 Aug 2022 17:56:32 +0200

On Wed, Aug 17, 2022 at 08:51 AM -07, Jakub Kicinski wrote:
> On Wed, 17 Aug 2022 16:33:33 +0200 Jakub Sitnicki wrote:
>> > Note to other netdev maintainers that based on the discussion about 
>> > the reuseport locking it's unclear whether we shouldn't also take 
>> > the callback lock...  
>> 
>> You're right. reuseport_array, psock, and kcm protect sk_user_data with
>> the callback lock, not the sock lock. Need to fix it.
>
> Where 'it' == current patch? Would you mind adding to the kdoc on
> sk_user_data that it's protected by the callback lock while at it?

Yes, will prepare a v3 for review. Sorry, should have been explicit.

Will add a kdoc. Great idea.