From: Tobias Waldekranz <tobias@waldekranz•com>
To: Vladimir Oltean <olteanv@gmail•com>,
Sunil Kovvuri <sunil.kovvuri@gmail•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Linux Netdev List <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
George Cherian <gcherian@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Sunil Goutham <sgoutham@marvell•com>,
Andrew Lunn <andrew@lunn•ch>,
Vladimir Oltean <vladimir.oltean@nxp•com>
Subject: Re: Query on new ethtool RSS hashing options
Date: Sat, 06 Mar 2021 22:16:12 +0100 [thread overview]
Message-ID: <87a6rgq8yr.fsf@waldekranz.com> (raw)
In-Reply-To: <20210306125427.tzt42itdwukz2cto@skbuf>
On Sat, Mar 06, 2021 at 14:54, Vladimir Oltean <olteanv@gmail•com> wrote:
> On Sat, Mar 06, 2021 at 05:38:14PM +0530, Sunil Kovvuri wrote:
>> > Can you share the format of the DSA tag? Is there a driver for it
>> > upstream? Do we need to represent it in union ethtool_flow_union?
>> >
>>
>> No, there is no driver for this tag in the kernel.
>> I have attached the tag format.
>> There are multiple DSA tag formats and representing them ethtool_flow
>> union would be difficult.
>> Hence wondering if it would be okay to add a more flexible way ie
>> offset and num_bytes from the start of packet.
>
> How sure are you that the tag format you've shared is not identical to
> the one parsed by net/dsa/tag_dsa.c?
That is indeed the format parsed by tag_dsa.c. Based on the layout in
the image, I am pretty sure that it is from the functional spec. of the
Amethyst (6393X). So while the format is supported, that specific device
is not. Hopefully that will change soon:
https://lore.kernel.org/netdev/cover.1610071984.git.pavana.sharma@digi.com/
As for the NIC: Marvell has an EVK for the Amethyst, connected to a
CN9130 SoC. The ethernet controllers in those can parse DSA tags in
hardware, so I would put my money on that.
The upstream driver (mvpp2) does not seem to support it though, AFAIK.
next prev parent reply other threads:[~2021-03-06 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 10:45 Query on new ethtool RSS hashing options Sunil Kovvuri
2021-03-05 23:07 ` Jakub Kicinski
2021-03-06 0:17 ` Andrew Lunn
2021-03-06 12:34 ` Sunil Kovvuri
2021-03-06 13:18 ` Vladimir Oltean
2021-03-08 13:25 ` Sunil Kovvuri
2021-03-08 13:42 ` Andrew Lunn
2021-03-06 14:32 ` Andrew Lunn
2021-03-08 13:19 ` Sunil Kovvuri
2021-03-06 12:08 ` Sunil Kovvuri
2021-03-06 12:54 ` Vladimir Oltean
2021-03-06 21:16 ` Tobias Waldekranz [this message]
2021-03-08 13:20 ` Sunil Kovvuri
2021-03-08 13:26 ` Sunil Kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6rgq8yr.fsf@waldekranz.com \
--to=tobias@waldekranz$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=gcherian@marvell$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=sunil.kovvuri@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox