From: Vlad Buslov <vlad@buslov•dev>
To: Jamal Hadi Salim <jhs@mojatatu•com>
Cc: Vlad Buslov <vladbu@nvidia•com>,
dsahern@gmail•com, stephen@networkplumber•org,
netdev@vger•kernel.org, davem@davemloft•net,
xiyou.wangcong@gmail•com, jiri@resnulli•us, ivecera@redhat•com,
Vlad Buslov <vladbu@mellanox•com>
Subject: Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump
Date: Fri, 16 Oct 2020 19:42:40 +0300 [thread overview]
Message-ID: <87a6wm15rz.fsf@buslov.dev> (raw)
In-Reply-To: <0bb6f625-c987-03d7-7225-eee03345168e@mojatatu.com>
On Fri 16 Oct 2020 at 19:07, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
> On 2020-10-16 10:42 a.m., Vlad Buslov wrote:
>> From: Vlad Buslov <vladbu@mellanox•com>
>>
>> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
>> tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
>> user requested it with following example CLI (-br for 'brief'):
>>
>> $ tc -s -brief filter show dev ens1f0 ingress
>> filter protocol all pref 49151 flower chain 0
>> filter protocol all pref 49151 flower chain 0 handle 0x1
>> not_in_hw
>> action order 1: Action statistics:
>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>> backlog 0b 0p requeues 0
>>
>> filter protocol all pref 49152 flower chain 0
>> filter protocol all pref 49152 flower chain 0 handle 0x1
>> not_in_hw
>> action order 1: Action statistics:
>> Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>> backlog 0b 0p requeues 0
>>
>
> Should the action name at least show up?
>
>
> cheers,
> jamal
All action print callbacks have arg==NULL check and return at the
beginning. To print action type we need either to have dedicated
'brief_dump' callback instead of reusing print_aop() or extend/refactor
print_aop() implementation for all actions to always print the type
before checking the arg. What do you suggest?
next prev parent reply other threads:[~2020-10-16 16:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 14:42 [PATCH iproute2-next v3 0/2] Implement filter terse dump mode support Vlad Buslov
2020-10-16 14:42 ` [PATCH iproute2-next v3 1/2] tc: skip actions that don't have options attribute when printing Vlad Buslov
2020-10-16 14:42 ` [PATCH iproute2-next v3 2/2] tc: implement support for terse dump Vlad Buslov
2020-10-16 16:07 ` Jamal Hadi Salim
2020-10-16 16:42 ` Vlad Buslov [this message]
2020-10-17 11:20 ` Jamal Hadi Salim
2020-10-18 12:16 ` Vlad Buslov
2020-10-19 13:48 ` Jamal Hadi Salim
2020-10-19 15:18 ` Vlad Buslov
2020-10-20 12:29 ` Jamal Hadi Salim
2020-10-21 8:19 ` Vlad Buslov
2020-10-22 14:05 ` Jamal Hadi Salim
2020-10-23 12:48 ` Vlad Buslov
2020-10-24 17:40 ` Jamal Hadi Salim
2020-10-26 11:28 ` Vlad Buslov
2020-10-26 14:52 ` David Ahern
2020-10-26 15:06 ` Vlad Buslov
2020-10-26 15:17 ` David Ahern
2020-10-26 17:12 ` Jamal Hadi Salim
2020-10-26 17:46 ` Vlad Buslov
2020-10-26 18:01 ` Jamal Hadi Salim
2020-10-26 18:03 ` Vlad Buslov
2020-10-26 19:56 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6wm15rz.fsf@buslov.dev \
--to=vlad@buslov$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=vladbu@mellanox$(echo .)com \
--cc=vladbu@nvidia$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox