From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
jakub.kicinski@netronome•com, sthemmin@microsoft•com,
dsahern@gmail•com, mlxsw@mellanox•com
Subject: Re: [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace
Date: Sat, 27 Jul 2019 12:25:10 +0200 [thread overview]
Message-ID: <87a7czwz95.fsf@toke.dk> (raw)
In-Reply-To: <20190727102116.GC2843@nanopsycho>
Jiri Pirko <jiri@resnulli•us> writes:
> Sat, Jul 27, 2019 at 12:12:48PM CEST, toke@redhat•com wrote:
>>Jiri Pirko <jiri@resnulli•us> writes:
>>
>>> From: Jiri Pirko <jiri@mellanox•com>
>>>
>>> Signed-off-by: Jiri Pirko <jiri@mellanox•com>
>>> ---
>>> devlink/devlink.c | 12 ++++++++++--
>>> man/man8/devlink.8 | 4 ++++
>>> 2 files changed, 14 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/devlink/devlink.c b/devlink/devlink.c
>>> index d8197ea3a478..9242cc05ad0c 100644
>>> --- a/devlink/devlink.c
>>> +++ b/devlink/devlink.c
>>> @@ -32,6 +32,7 @@
>>> #include "mnlg.h"
>>> #include "json_writer.h"
>>> #include "utils.h"
>>> +#include "namespace.h"
>>>
>>> #define ESWITCH_MODE_LEGACY "legacy"
>>> #define ESWITCH_MODE_SWITCHDEV "switchdev"
>>> @@ -6332,7 +6333,7 @@ static int cmd_health(struct dl *dl)
>>> static void help(void)
>>> {
>>> pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n"
>>> - " devlink [ -f[orce] ] -b[atch] filename\n"
>>> + " devlink [ -f[orce] ] -b[atch] filename -N[etns]
>>> netnsname\n"
>>
>>'ip' uses lower-case n for this; why not be consistent?
>
> Because "n" is taken :/
Ah, right, that was right there on the line below in the patch context.
Oops, by bad (and too bad!)
-Toke
next prev parent reply other threads:[~2019-07-27 10:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 9:44 [patch net-next 0/3] net: devlink: Finish network namespace support Jiri Pirko
2019-07-27 9:44 ` [patch net-next 1/3] net: devlink: allow to change namespaces Jiri Pirko
2019-07-29 17:52 ` David Miller
2019-07-30 6:05 ` Jiri Pirko
2019-07-27 9:44 ` [patch net-next 2/3] net: devlink: export devlink net set/get helpers Jiri Pirko
2019-07-27 9:44 ` [patch net-next 3/3] netdevsim: create devlink and netdev instances in namespace Jiri Pirko
2019-07-29 18:59 ` Jakub Kicinski
2019-07-30 6:06 ` Jiri Pirko
2019-07-30 17:14 ` Jakub Kicinski
2019-07-30 21:03 ` Jiri Pirko
2019-07-27 10:05 ` [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace Jiri Pirko
2019-07-27 10:12 ` Toke Høiland-Jørgensen
2019-07-27 10:21 ` Jiri Pirko
2019-07-27 10:25 ` Toke Høiland-Jørgensen [this message]
2019-07-29 20:21 ` David Ahern
2019-07-30 6:07 ` Jiri Pirko
2019-07-29 20:17 ` David Ahern
2019-07-27 10:05 ` [patch iproute2 2/2] devlink: add support for network namespace change Jiri Pirko
2019-07-29 20:17 ` [patch net-next 0/3] net: devlink: Finish network namespace support David Ahern
2019-07-30 6:08 ` Jiri Pirko
2019-07-31 21:50 ` David Ahern
2019-07-31 22:02 ` Jakub Kicinski
2019-07-31 22:07 ` David Ahern
2019-07-31 22:28 ` Jakub Kicinski
2019-07-31 22:31 ` David Ahern
2019-08-02 7:42 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7czwz95.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=mlxsw@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sthemmin@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox