From: Kurt Kanzenbach <kurt@linutronix•de>
To: Joe Damato <jdamato@fastly•com>
Cc: Tony Nguyen <anthony.l.nguyen@intel•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Gerhard Engleder <gerhard@engleder-embedded•com>,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org
Subject: Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up
Date: Thu, 20 Feb 2025 08:44:51 +0100 [thread overview]
Message-ID: <87bjux3vrg.fsf@kurt.kurt.home> (raw)
In-Reply-To: <Z7YaLuho0hXL7Jb1@LQ3V64L9R2>
[-- Attachment #1: Type: text/plain, Size: 3982 bytes --]
On Wed Feb 19 2025, Joe Damato wrote:
> On Wed, Feb 19, 2025 at 03:03:36PM +0100, Kurt Kanzenbach wrote:
>> On Tue Feb 18 2025, Joe Damato wrote:
>> > On Tue, Feb 18, 2025 at 04:18:19PM -0500, Joe Damato wrote:
>> >> On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote:
>> >> > This is a follow up for the igb XDP/ZC implementation. The first two
>> >> > patches link the IRQs and queues to NAPI instances. This is required to
>> >> > bring back the XDP/ZC busy polling support. The last patch removes
>> >> > undesired IRQs (injected via igb watchdog) while busy polling with
>> >> > napi_defer_hard_irqs and gro_flush_timeout set.
>> >> >
>> >> > Signed-off-by: Kurt Kanzenbach <kurt@linutronix•de>
>> >> > ---
>> >> > Changes in v2:
>> >> > - Take RTNL lock in PCI error handlers (Joe)
>> >> > - Fix typo in commit message (Gerhard)
>> >> > - Use netif_napi_add_config() (Joe)
>> >> > - Link to v1: https://lore.kernel.org/r/20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de
>> >>
>> >> Thanks for sending a v2.
>> >>
>> >> My comment from the previous series still stands, which simply that
>> >> I have no idea if the maintainers will accept changes using this API
>> >> or prefer to wait until Stanislav's work [1] is completed to remove
>> >> the RTNL requirement from this API altogether.
>> >
>> > Also, may be worth running the newly added XSK test with the NETIF
>> > env var set to the igb device? Assuming eth0 is your igb device:
>> >
>> > NETIF=eth0 ./tools/testing/selftests/drivers/net/queues.py
>> >
>> > should output:
>> >
>> > KTAP version 1
>> > 1..4
>> > ok 1 queues.get_queues
>> > ok 2 queues.addremove_queues
>> > ok 3 queues.check_down
>> > ok 4 queues.check_xdp
>> > # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
>> >
>> > Note the check_xdp line above.
>> >
>>
>> Sure, why not. Seems to work.
>
> Thanks for testing it.
>
>> |root@apl1:~/linux# uname -a
>> |Linux apl1 6.14.0-rc2+ #2 SMP PREEMPT_RT Wed Feb 19 14:41:23 CET 2025 x86_64 GNU/Linux
>> |root@apl1:~/linux# NETIF=enp2s0 ./tools/testing/selftests/drivers/net/queues.py
>> |KTAP version 1
>> |1..4
>> |ok 1 queues.get_queues
>> |ok 2 queues.addremove_queues
>> |ok 3 queues.check_down
>> |ok 4 queues.check_xdp
>> |# Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0
>>
>> Has this xsk netlink attribute been added fairly recently? The test
>> failed on my kernel from a few days ago (kernel from today works).
>
> Yes, it was just merged, see the commit date here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=788e52e2b66844301fe09f3372d46d8c62f6ebe4
>
>> I think there's room for improvement though:
>>
>> |root@apl1:~/linux# NETIF=enp2s0 ./tools/testing/selftests/drivers/net/queues.py
>> |KTAP version 1
>> |1..4
>> |ok 1 queues.get_queues
>> |ok 2 queues.addremove_queues
>> |ok 3 queues.check_down
>> |# Exception| Traceback (most recent call last):
>> |# Exception| File "/root/linux/tools/testing/selftests/net/lib/py/ksft.py", line 218, in ksft_run
>> |# Exception| case(*args)
>> |# Exception| File "/root/linux/./tools/testing/selftests/drivers/net/queues.py", line 53, in check_xdp
>> |# Exception| ksft_eq(q['xsk'], {})
>> |# Exception| ~^^^^^^^
>> |# Exception| KeyError: 'xsk'
>> |not ok 4 queues.check_xdp
>> |# Totals: pass:3 fail:1 xfail:0 xpass:0 skip:0 error:0
>>
>> I'd assume this shouldn't be a Python exception, but rather say
>> something like "Expected xsk attribute, but none found. Fix the driver!" :)
>>
>> While at it would you mind to add a newline to the xdp_helper usage
>> line (and fix the one typo)?
>
> Jakub currently has a series out to change the test a bit and
> improve it overall, see:
>
> https://lore.kernel.org/netdev/20250218195048.74692-1-kuba@kernel.org/
>
Great that Jakub is already on it. I've replied in that thread. Thanks.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2025-02-20 7:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 11:31 [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Kurt Kanzenbach
2025-02-17 11:31 ` [PATCH iwl-next v2 1/4] igb: Link IRQs to NAPI instances Kurt Kanzenbach
2025-02-28 9:00 ` [Intel-wired-lan] " Rinitha, SX
2025-02-17 11:31 ` [PATCH iwl-next v2 2/4] igb: Link queues " Kurt Kanzenbach
2025-02-18 21:13 ` Joe Damato
2025-02-19 7:41 ` Kurt Kanzenbach
2025-02-19 17:55 ` Joe Damato
2025-02-20 7:43 ` Kurt Kanzenbach
2025-02-28 9:00 ` [Intel-wired-lan] " Rinitha, SX
2025-03-07 22:03 ` Tony Nguyen
2025-03-10 8:34 ` Joe Damato
2025-03-10 16:10 ` Kurt Kanzenbach
2025-02-17 11:31 ` [PATCH iwl-next v2 3/4] igb: Add support for persistent NAPI config Kurt Kanzenbach
2025-02-18 21:15 ` Joe Damato
2025-02-21 13:51 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-02-28 9:00 ` Rinitha, SX
2025-02-17 11:31 ` [PATCH iwl-next v2 4/4] igb: Get rid of spurious interrupts Kurt Kanzenbach
2025-02-21 12:44 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-03-07 10:26 ` Kumari, Sweta
2025-02-18 21:18 ` [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Joe Damato
2025-02-18 22:00 ` Joe Damato
2025-02-19 14:03 ` Kurt Kanzenbach
2025-02-19 17:51 ` Joe Damato
2025-02-20 7:44 ` Kurt Kanzenbach [this message]
2025-02-19 7:39 ` Kurt Kanzenbach
2025-02-20 2:06 ` Jakub Kicinski
2025-02-21 20:53 ` Joe Damato
2025-02-21 22:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjux3vrg.fsf@kurt.kurt.home \
--to=kurt@linutronix$(echo .)de \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gerhard@engleder-embedded$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jdamato@fastly$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox