From: Kurt Kanzenbach <kurt@linutronix•de>
To: "Ruinskiy, Dima" <dima.ruinskiy@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
davem@davemloft•net, kuba@kernel•org, pabeni@redhat•com,
edumazet@google•com, netdev@vger•kernel.org
Cc: sasha.neftin@intel•com, vitaly.lifshits@intel•com,
maciej.fijalkowski@intel•com, magnus.karlsson@intel•com,
ast@kernel•org, daniel@iogearbox•net, hawk@kernel•org,
john.fastabend@gmail•com, bpf@vger•kernel.org,
bigeasy@linutronix•de,
Vinicius Costa Gomes <vinicius.gomes@intel•com>,
Simon Horman <horms@kernel•org>,
Mor Bar-Gabay <morx.bar.gabay@intel•com>
Subject: Re: [PATCH net-next 2/6] igc: Get rid of spurious interrupts
Date: Thu, 05 Sep 2024 11:44:20 +0200 [thread overview]
Message-ID: <87bk12sadn.fsf@kurt.kurt.home> (raw)
In-Reply-To: <b5120c1e-4312-40da-8c11-c0af035dbbb5@intel.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Thu Sep 05 2024, Dima Ruinskiy wrote:
> On 31/08/2024 0:04, Tony Nguyen wrote:
>> - wr32(IGC_ICS, IGC_ICS_RXDMT0);
>> + struct igc_ring *rx_ring = adapter->rx_ring[0];
>> +
>> + if (test_bit(IGC_RING_FLAG_RX_ALLOC_FAILED, &rx_ring->flags)) {
>> + clear_bit(IGC_RING_FLAG_RX_ALLOC_FAILED, &rx_ring->flags);
>> + wr32(IGC_ICS, IGC_ICS_RXDMT0);
>> + }
> I have some concerns specifically about this code (Legacy/MSI interrupt
> case). The code only checks the IGC_RING_FLAG_RX_ALLOC_FAILED flag of
> ring 0. What if the failure was on another ring? It seems proper to
> iterate over all Rx rings in the adapter (I believe igc can have up to 4).
In case of Legacy/MSI only one vector, one rx queue and one tx queue is
utilized. The MSI-X code has to check for all rings, which it does.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2024-09-05 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 21:04 [PATCH net-next 0/6][pull request] Intel Wired LAN Driver Updates 2024-08-30 (igc, e1000e, i40e) Tony Nguyen
2024-08-30 21:04 ` [PATCH net-next 1/6] igc: Add MQPRIO offload support Tony Nguyen
2024-08-30 21:04 ` [PATCH net-next 2/6] igc: Get rid of spurious interrupts Tony Nguyen
2024-09-05 6:16 ` Ruinskiy, Dima
2024-09-05 9:44 ` Kurt Kanzenbach [this message]
2024-08-30 21:04 ` [PATCH net-next 3/6] igc: Add Energy Efficient Ethernet ability Tony Nguyen
2024-09-03 19:49 ` Jakub Kicinski
2024-09-05 7:07 ` Lifshits, Vitaly
2024-08-30 21:04 ` [PATCH net-next 4/6] igc: Move the MULTI GBT AN Control Register to _regs file Tony Nguyen
2024-08-30 21:04 ` [PATCH net-next 5/6] e1000e: avoid failing the system during pm_suspend Tony Nguyen
2024-08-30 21:04 ` [PATCH net-next 6/6] i40e: Add Energy Efficient Ethernet ability for X710 Base-T/KR/KX cards Tony Nguyen
2024-09-03 20:40 ` [PATCH net-next 0/6][pull request] Intel Wired LAN Driver Updates 2024-08-30 (igc, e1000e, i40e) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk12sadn.fsf@kurt.kurt.home \
--to=kurt@linutronix$(echo .)de \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dima.ruinskiy@intel$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=morx.bar.gabay@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sasha.neftin@intel$(echo .)com \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=vitaly.lifshits@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox