Subject: Re: [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask

From: Vinicius Costa Gomes <[email-masked]>
Date: Tue, 28 Nov 2023 15:37:24 -0800

Kurt Kanzenbach <[email-masked]> writes:

> Hi,
>
> currently it is possible to configure receive queue assignment using the VLAN
> TCI field with arbitrary masks. However, the hardware only supports steering
> either by full TCI or the priority (PCP) field. In case a wrong mask is given by
> the user the driver will silently convert it into a PCP filter which is not
> desired. Therefore, add a check for it.
>
> Patches #1 to #4 are minor things found along the way.
>

Some very minor things: patches 2,3 and 4 have extra long lines in their
commit messages that checkpatch.pl doesn't seem to like.

Patches 4 and 5 read more like fixes to me. I think they could be
proposed to -net, as they contain fixes to user visible issues. Do you
think that makes sense?

As for the code, feel free to add my Ack to the series:

Acked-by: Vinicius Costa Gomes <[email-masked]>

Cheers,
-- 
Vinicius