From: "Bjørn Mork" <bjorn@mork•no>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, jasowang@redhat•com
Subject: Re: [PATCH net,stable] tun: fix vlan packet truncation
Date: Tue, 17 Apr 2018 22:41:38 +0200 [thread overview]
Message-ID: <87bmehftvh.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20180417.134727.1681639113353628332.davem@davemloft.net> (David Miller's message of "Tue, 17 Apr 2018 13:47:27 -0400 (EDT)")
David Miller <davem@davemloft•net> writes:
> The VLAN business might be bogus, and needs to be removed.
>
> However, the pskb_trim() has to stay in some form. I think this is what
> Jason is trying to say.
>
> The semantics of running a BPF program is that the program returns the
> desired packet length. We must truncate the packet to the length
> returned by the BPF program, therefore.
Right. That's obvious when I look closer at it. Sorry for being so
slow... New version coming up.
Bjørn
prev parent reply other threads:[~2018-04-17 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 22:00 [PATCH net,stable] tun: fix vlan packet truncation Bjørn Mork
2018-04-17 2:13 ` Jason Wang
2018-04-17 8:08 ` Bjørn Mork
2018-04-17 17:47 ` David Miller
2018-04-17 20:41 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmehftvh.fsf@miraculix.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=davem@davemloft$(echo .)net \
--cc=jasowang@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox