From: Kalle Valo <kvalo@qca•qualcomm.com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Joe Perches <joe@perches•com>,
Julia Lawall <julia.lawall@lip6•fr>,
"Luis R. Rodriguez" <mcgrof@do-not-panic•com>,
netdev <netdev@vger•kernel.org>, <ath10k@lists•infradead.org>,
"John W. Linville" <linville@tuxdriver•com>
Subject: Re: [PATCH net-next] ath10k: wmi: Convert use of 6 to ETH_ALEN
Date: Thu, 3 Oct 2013 07:54:39 +0300 [thread overview]
Message-ID: <87bo37ymwg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380775478.19002.139.camel@edumazet-glaptop.roam.corp.google.com> (Eric Dumazet's message of "Wed, 2 Oct 2013 21:44:38 -0700")
Eric Dumazet <eric.dumazet@gmail•com> writes:
> On Thu, 2013-10-03 at 07:34 +0300, Kalle Valo wrote:
>
>> Do you mean '6' or the union? The 6 can replaced with ETH_ALEN AFAICS.
>> But the union is needed for aligning the packets as firmware expects
>> them.
>
> I mean the 6, of course, since Joe seems to actively track them, as if
> ETH_ALEN could change eventually, you never know.
>
> I am worrying this will take another hundred patches ...
Ah, ok.
> Regarding this union, the __packed attributes seem overkill, no ???
Yeah, they do. This should be enough, right?
struct wmi_mac_addr {
union {
u8 addr[6];
struct {
u32 word0;
u32 word1;
};
};
} __packed;
--
Kalle Valo
next prev parent reply other threads:[~2013-10-03 4:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 2:04 [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN Joe Perches
[not found] ` <87k3hw469z.fsf@kamboji.qca.qualcomm.com>
2013-10-02 6:40 ` Joe Perches
2013-10-02 17:44 ` Luis R. Rodriguez
2013-10-02 18:02 ` Joe Perches
2013-10-02 22:38 ` Julia Lawall
2013-10-03 0:09 ` Joe Perches
2013-10-03 0:28 ` Joe Perches
2013-10-03 3:31 ` Joe Perches
2013-10-03 3:39 ` [PATCH net-next] ath10k: wmi: Convert use of 6 " Joe Perches
2013-10-03 3:44 ` David Miller
2013-10-03 4:18 ` Eric Dumazet
2013-10-03 4:34 ` Kalle Valo
2013-10-03 4:44 ` Eric Dumazet
2013-10-03 4:54 ` Kalle Valo [this message]
2013-10-03 5:09 ` Joe Perches
2013-10-03 5:24 ` Eric Dumazet
2013-10-03 5:34 ` Joe Perches
2013-10-03 5:47 ` Julia Lawall
2013-10-03 6:00 ` Eric Dumazet
2013-10-03 6:07 ` Joe Perches
2013-10-03 6:32 ` Julia Lawall
2013-10-03 4:56 ` Joe Perches
2013-10-03 5:43 ` Julia Lawall
2013-10-03 5:41 ` [PATCH net-next] net:drivers/net: Miscellaneous conversions " Julia Lawall
2013-10-02 7:27 ` Arend van Spriel
2013-10-02 21:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo37ymwg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca$(echo .)qualcomm.com \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=julia.lawall@lip6$(echo .)fr \
--cc=linville@tuxdriver$(echo .)com \
--cc=mcgrof@do-not-panic$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox