Subject: Re: [PATCH 0/5] Call netif_carrier_off() after register_netdev()

From: Bjørn Mork <[email-masked]>
Date: Wed, 15 Aug 2012 13:40:52 +0200

Ben Hutchings <[email-masked]> writes:

> But if you do it beforehand then it doesn't have the intended effect.
> (Supposed to be fixed by 22604c866889c4b2e12b73cbf1683bda1b72a313, which
> had to be reverted: c276e098d3ee33059b4a1c747354226cec58487c.)
>
> So you have to do it after, but without dropping the RTNL lock in
> between.

So you may want to add something like

int register_netdev_carrier_off(struct net_device *dev)
{
	int err;

	rtnl_lock();
	err = register_netdevice(dev);
        if (!err)
                set_bit(__LINK_STATE_NOCARRIER, &dev->state)
	rtnl_unlock();
	return err;
}

for these drivers?

Bjørn