Subject: Re: [PATCH] allow to configure tcp_retries1 and tcp_retries2 per TCP socket

From: Andi Kleen <[email-masked]>
Date: Thu, 10 Jun 2010 19:00:19 +0200

Salvador Fandino <[email-masked]> writes:

> The included patch adds support for setting the tcp_retries1 and
> tcp_retries2 options in a per socket fashion as it is done for the
> keepalive options TCP_KEEPIDLE, TCP_KEEPCNT and TCP_KEEPINTVL.
>
> The issue I am trying to solve is that when a socket has data queued for
> delivering, the keepalive logic is not triggered. Instead, the
> tcp_retries1/2 parameters are used to determine how many delivering
> attempts should be performed before giving up.

And why exactly do you need new tunables to solve this?

>
> The patch is very straight forward and just replicates similar
> functionality. There is one thing I am not completely sure and is if the
> new per-socket fields should go into inet_connection_sock instead of
> into tcp_sock.

tcp_sock is already quite big (>2k on 64bit) 

IMHO any new fields in there need very good justification.

-Andi

-- 
[email-masked] -- Speaking for myself only.