From: Petr Machata <petrm@nvidia•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>,
<edumazet@google•com>, <pabeni@redhat•com>,
<andrew+netdev@lunn•ch>, <horms@kernel•org>, <shuah@kernel•org>,
<willemb@google•com>, <petrm@nvidia•com>,
<donald.hunter@gmail•com>, <michael.chan@broadcom•com>,
<pavan.chebbi@broadcom•com>, <linux-kselftest@vger•kernel.org>
Subject: Re: [PATCH net-next 5/9] selftests: drv-net: give HW stats sync time extra 25% of margin
Date: Fri, 6 Feb 2026 15:40:30 +0100 [thread overview]
Message-ID: <87cy2h29vj.fsf@nvidia.com> (raw)
In-Reply-To: <20260205220541.2992807-6-kuba@kernel.org>
Jakub Kicinski <kuba@kernel•org> writes:
> There are transient failures for devices which update stats
> periodically, especially if it's the FW DMA'ing the stats
> rather than host periodic work querying the FW. Wait 25%
> longer than strictly necessary.
>
> For devices which don't report stats-block-usecs we retain
> 25 msec as the default wait time.
Right, because now the default is 0.2, and we apply the 1.25 multiplier.
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Petr Machata <petrm@nvidia•com>
> ---
> tools/testing/selftests/drivers/net/lib/py/env.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/drivers/net/lib/py/env.py b/tools/testing/selftests/drivers/net/lib/py/env.py
> index 41cc248ac848..39a98eb2592e 100644
> --- a/tools/testing/selftests/drivers/net/lib/py/env.py
> +++ b/tools/testing/selftests/drivers/net/lib/py/env.py
> @@ -285,7 +285,7 @@ from .remote import Remote
> if "Operation not supported" not in e.cmd.stderr:
> raise
>
> - self._stats_settle_time = 0.025 + \
> - data.get('stats-block-usecs', 0) / 1000 / 1000
> + self._stats_settle_time = \
> + 1.25 * data.get('stats-block-usecs', 20000) / 1000 / 1000
>
> time.sleep(self._stats_settle_time)
next prev parent reply other threads:[~2026-02-06 15:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 22:05 [PATCH net-next 0/9] net: stats, tools, driver tests for HW GRO Jakub Kicinski
2026-02-05 22:05 ` [PATCH net-next 1/9] eth: bnxt: gather and report HW-GRO stats Jakub Kicinski
2026-02-05 22:44 ` Michael Chan
2026-02-06 0:24 ` Jakub Kicinski
2026-02-05 22:05 ` [PATCH net-next 2/9] tools: ynltool: factor out qstat dumping Jakub Kicinski
2026-02-06 14:58 ` Petr Machata
2026-02-05 22:05 ` [PATCH net-next 3/9] tools: ynltool: add qstats analysis for HW-GRO efficiency / savings Jakub Kicinski
2026-02-06 13:44 ` Petr Machata
2026-02-05 22:05 ` [PATCH net-next 4/9] selftests: net: move gro to lib for HW vs SW reuse Jakub Kicinski
2026-02-06 15:01 ` Petr Machata
2026-02-05 22:05 ` [PATCH net-next 5/9] selftests: drv-net: give HW stats sync time extra 25% of margin Jakub Kicinski
2026-02-06 14:40 ` Petr Machata [this message]
2026-02-05 22:05 ` [PATCH net-next 6/9] selftests: drv-net: gro: use SO_TXTIME to schedule packets together Jakub Kicinski
2026-02-06 15:19 ` Petr Machata
2026-02-05 22:05 ` [PATCH net-next 7/9] selftests: drv-net: gro: test GRO stats Jakub Kicinski
2026-02-05 22:05 ` [PATCH net-next 8/9] selftests: drv-net: gro: add test for packet ordering Jakub Kicinski
2026-02-05 22:05 ` [PATCH net-next 9/9] selftests: drv-net: gro: add a test for HW-GRO depth Jakub Kicinski
2026-02-06 15:36 ` [PATCH net-next 0/9] net: stats, tools, driver tests for HW GRO Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy2h29vj.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox