From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Simon Horman <horms@kernel•org>, Eric Dumazet <edumazet@google•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
netdev@vger•kernel.org, eric.dumazet@gmail•com,
cake@lists•bufferbloat.net
Subject: Re: [PATCH net-next 02/14] net_sched: cake: implement lockless cake_dump()
Date: Wed, 17 Apr 2024 14:25:08 +0200 [thread overview]
Message-ID: <87cyqouqfv.fsf@toke.dk> (raw)
In-Reply-To: <20240417083549.GA3846178@kernel.org>
Simon Horman <horms@kernel•org> writes:
> + Toke Høiland-Jørgensen <toke@toke•dk>
> cake@lists•bufferbloat.net
Thanks!
> On Mon, Apr 15, 2024 at 01:20:42PM +0000, Eric Dumazet wrote:
>> Instead of relying on RTNL, cake_dump() can use READ_ONCE()
>> annotations, paired with WRITE_ONCE() ones in cake_change().
>>
>> Signed-off-by: Eric Dumazet <edumazet@google•com>
Just to be sure I understand this correctly: the idea is that with
READ/WRITE_ONCE annotations, we can dump the qdisc options without
taking the RTNL lock. This means that a dump not be consistent across a
concurrent reconfig that changes multiple parameters, but each parameter
will be either the new or the old value. Right?
-Toke
next prev parent reply other threads:[~2024-04-17 12:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 13:20 [PATCH net-next 00/14] net_sched: first series for RTNL-less qdisc dumps Eric Dumazet
2024-04-15 13:20 ` [PATCH net-next 01/14] net_sched: sch_fq: implement lockless fq_dump() Eric Dumazet
2024-04-16 18:19 ` Simon Horman
2024-04-16 18:33 ` Eric Dumazet
2024-04-17 8:45 ` Eric Dumazet
2024-04-17 9:00 ` Simon Horman
2024-04-17 9:02 ` Eric Dumazet
2024-04-17 9:23 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 02/14] net_sched: cake: implement lockless cake_dump() Eric Dumazet
2024-04-17 8:35 ` Simon Horman
2024-04-17 8:54 ` Eric Dumazet
2024-04-17 9:24 ` Simon Horman
2024-04-17 12:25 ` Toke Høiland-Jørgensen [this message]
2024-04-15 13:20 ` [PATCH net-next 03/14] net_sched: sch_cbs: implement lockless cbs_dump() Eric Dumazet
2024-04-17 9:27 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 04/14] net_sched: sch_choke: implement lockless choke_dump() Eric Dumazet
2024-04-17 13:14 ` Simon Horman
2024-04-17 13:41 ` Eric Dumazet
2024-04-17 14:44 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 05/14] net_sched: sch_codel: implement lockless codel_dump() Eric Dumazet
2024-04-17 15:59 ` Simon Horman
2024-04-17 16:05 ` Eric Dumazet
2024-04-17 16:21 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 06/14] net_sched: sch_tfs: implement lockless etf_dump() Eric Dumazet
2024-04-17 16:27 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 07/14] net_sched: sch_ets: implement lockless ets_dump() Eric Dumazet
2024-04-17 16:54 ` Simon Horman
2024-04-17 17:08 ` Eric Dumazet
2024-04-17 17:17 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 08/14] net_sched: sch_fifo: implement lockless __fifo_dump() Eric Dumazet
2024-04-15 13:20 ` [PATCH net-next 09/14] net_sched: sch_fq_codel: implement lockless fq_codel_dump() Eric Dumazet
2024-04-17 17:07 ` Simon Horman
2024-04-17 17:14 ` Eric Dumazet
2024-04-17 17:22 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 10/14] net_sched: sch_fq_pie: implement lockless fq_pie_dump() Eric Dumazet
2024-04-17 17:13 ` Simon Horman
2024-04-17 17:15 ` Eric Dumazet
2024-04-17 17:23 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 11/14] net_sched: sch_hfsc: implement lockless accesses to q->defcls Eric Dumazet
2024-04-15 13:20 ` [PATCH net-next 12/14] net_sched: sch_hhf: implement lockless hhf_dump() Eric Dumazet
2024-04-17 17:26 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 13/14] net_sched: sch_pie: implement lockless pie_dump() Eric Dumazet
2024-04-17 17:28 ` Simon Horman
2024-04-15 13:20 ` [PATCH net-next 14/14] net_sched: sch_skbprio: implement lockless skbprio_dump() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyqouqfv.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=cake@lists$(echo .)bufferbloat.net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox