Subject: Re: [PATCH net-next 02/14] net_sched: cake: implement lockless cake_dump()

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Wed, 17 Apr 2024 14:25:08 +0200

Simon Horman <[email-masked]> writes:

> + Toke Høiland-Jørgensen <[email-masked]>
>   [email-masked]

Thanks!

> On Mon, Apr 15, 2024 at 01:20:42PM +0000, Eric Dumazet wrote:
>> Instead of relying on RTNL, cake_dump() can use READ_ONCE()
>> annotations, paired with WRITE_ONCE() ones in cake_change().
>> 
>> Signed-off-by: Eric Dumazet <[email-masked]>

Just to be sure I understand this correctly: the idea is that with
READ/WRITE_ONCE annotations, we can dump the qdisc options without
taking the RTNL lock. This means that a dump not be consistent across a
concurrent reconfig that changes multiple parameters, but each parameter
will be either the new or the old value. Right?

-Toke