From: Vladimir Nikishkin <vladimir@nikishkin•pw>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com,
eng.alaamohamedsoliman.am@gmail•com, gnault@redhat•com,
razor@blackwall•org, idosch@nvidia•com, liuhangbin@gmail•com,
eyal.birger@gmail•com, jtoppins@redhat•com
Subject: Re: [PATCH iproute2-next v4] ip-link: add support for nolocalbypass in vxlan
Date: Fri, 19 May 2023 11:50:03 +0800 [thread overview]
Message-ID: <87cz2xt1rb.fsf@laptop.lockywolf.net> (raw)
In-Reply-To: <20230518084908.7c0e14d4@hermes.local>
Stephen Hemminger <stephen@networkplumber•org> writes:
> On Thu, 18 May 2023 21:46:01 +0800
> Vladimir Nikishkin <vladimir@nikishkin•pw> wrote:
>
>> + if (tb[IFLA_VXLAN_LOCALBYPASS]) {
>> + __u8 localbypass = rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS]);
>> +
>> + print_bool(PRINT_JSON, "localbypass", NULL, localbypass);
>> + if (localbypass) {
>> + print_string(PRINT_FP, NULL, "localbypass ", NULL);
>> + } else {
>> + print_string(PRINT_FP, NULL, "nolocalbypass ", NULL);
>> + }
>> + }
>
> You don't have to print anything if nolocalbypass. Use presence as
> a boolean in JSON.
>
> I.e.
> if (tb[IFLA_VXLAN_LOCALBYPASS] &&
> rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS])) {
> print_bool(PRINT_ANY, "localbypass", "localbypass", true);
> }
>
> That is what other options do.
> Follows the best practices for changes to existing programs: your
> new feature should look like all the others.
Sorry, I do not understand. I intended to do exactly that, and I copied
and adjusted for the option name the code currently used for the
"udpcsum" option. Which is exactly
if (is_json_context()) {
print_bool(PRINT_ANY, "udp_csum", NULL, udp_csum);
} else {
if (!udp_csum)
fputs("no", f);
fputs("udpcsum ", f);
}
I just replaced that option name with [no]localbypass. Fairly
straightforward, prints noudpcsum or udpcsum. Later Andrea C
Then Andrea Claudi suggested that print_bool knows about the json
context itself, so the outer check is not needed, so I removed that.
But the "model option" I used (really the simplest one), does have
output both when set to true, and when set to false. I have neither an
opinion on this nor an understanding what is better for scripting. But I
do not understand the suggestion "do like the other options do", when
seemingly, other options do what I suggest in the first place.
--
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
--
Fastmail.
next prev parent reply other threads:[~2023-05-19 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 13:46 [PATCH iproute2-next v4] ip-link: add support for nolocalbypass in vxlan Vladimir Nikishkin
2023-05-18 15:49 ` Stephen Hemminger
2023-05-19 3:50 ` Vladimir Nikishkin [this message]
2023-05-19 9:11 ` Andrea Claudi
2023-05-19 16:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz2xt1rb.fsf@laptop.lockywolf.net \
--to=vladimir@nikishkin$(echo .)pw \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eng.alaamohamedsoliman.am@gmail$(echo .)com \
--cc=eyal.birger@gmail$(echo .)com \
--cc=gnault@redhat$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=jtoppins@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox