From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: "Linus Lüssing" <ll@simonwunderlich•de>,
"Adrian Chadd" <adrian@freebsd•org>,
"Linus Lüssing" <linus.luessing@c0d3•blue>
Cc: Johannes Berg <johannes.berg@intel•com>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Kalle Valo <kvalo@kernel•org>, Felix Fietkau <nbd@nbd•name>,
Simon Wunderlich <sw@simonwunderlich•de>,
Sven Eckelmann <sven@narfation•org>,
ath10k <ath10k@lists•infradead.org>,
linux-wireless <linux-wireless@vger•kernel.org>,
netdev <netdev@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] mac80211: Fix wrong channel bandwidths reported for aggregates
Date: Wed, 20 Jul 2022 12:57:34 +0200 [thread overview]
Message-ID: <87cze0kq5d.fsf@toke.dk> (raw)
In-Reply-To: <31e87fa2-6fea-5fe2-ab80-6050da9af7ce@simonwunderlich.de>
Linus Lüssing <ll@simonwunderlich•de> writes:
> On 19/07/2022 17:03, Adrian Chadd wrote:
>> Hi!
>>
>> It's not a hardware bug. Dating back to the original AR5416 11n chip,
>> most flags aren't valid for subframes in an aggregate. Only the final
>> frame has valid flags. This was explicitly covered internally way back
>> when.
>
> Ah, thanks for the clarification! I see it in the datasheet for the
> QCA9531, too, now. And thanks for the confirmation, that what we are
> doing so far is not correct for ath9k.
>
> Words 0+2 are valid for all RX descriptors, 0+2+11 valid for the last RX
> descriptor of each packet and 0-11 for the last RX descriptor of an
> aggregate or last RX descriptor of a stand-alone packet. Or in other
> words, word 4, which contains the 20 vs. 40 MHz indicator, is invalid
> for any aggregate sub-frame other than the last one. I can rename that
> in the commit message.
>
>
> Another approach that also came to my mind was introducing more explicit
> flags in cfg80211.h's "struct rate_info", like a RATE_INFO_BW_UNKNOWN in
> "enum rate_info_bw" and/or RATE_INFO_FLAGS_UNKNOWN in "enum
> rate_info_flags". And setting those flags in ath9k_cmn_process_rate().
>
> The current approach is smaller though, as it simply uses the already
> existing flags. If anyone has any preferences, please let me know.
I have no objections to doing it in mac80211 like you're proposing here :)
-Toke
next prev parent reply other threads:[~2022-07-20 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 22:28 [PATCH] mac80211: Fix wrong channel bandwidths reported for aggregates Linus Lüssing
2022-07-19 15:03 ` Adrian Chadd
2022-07-19 15:36 ` Linus Lüssing
2022-07-20 10:57 ` Toke Høiland-Jørgensen [this message]
2022-07-21 14:43 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cze0kq5d.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=adrian@freebsd$(echo .)org \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linus.luessing@c0d3$(echo .)blue \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=ll@simonwunderlich$(echo .)de \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sven@narfation$(echo .)org \
--cc=sw@simonwunderlich$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox