Subject: Re: [PATCH bpf] selftests/bpf: Declare bpf_log_buf variables as static

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Tue, 03 Mar 2020 09:09:58 +0100

Alexei Starovoitov <[email-masked]> writes:

> On Mon, Mar 02, 2020 at 03:53:48PM +0100, Toke HÃ¸iland-JÃ¸rgensen wrote:
>> The cgroup selftests did not declare the bpf_log_buf variable as static, leading
>> to a linker error with GCC 10 (which defaults to -fno-common). Fix this by
>> adding the missing static declarations.
>> 
>> Fixes: 257c88559f36 ("selftests/bpf: Convert test_cgroup_attach to prog_tests")
>> Signed-off-by: Toke HÃ¸iland-JÃ¸rgensen <[email-masked]>
>
> Applied to bpf-next.
> It's hardly a fix. Fixes tag doesn't make it a fix in my mind.

It fixes a compile error of selftests with GCC 10; how is that not a
fix? We found it while setting up a CI test compiling Linus' tree on
Fedora rawhide, so it does happen in the wild.

> I really see no point rushing it into bpf->net->Linus's tree at this point.

Well if you're not pushing any other fixes then OK, sure, no reason to
go through the whole process just for this. But if you end up pushing
another round of fixes anyway, please include this as well. If not, I
guess we can wait :)

-Toke