public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: arno@natisbad•org (Arnaud Ebalard)
To: Willy Tarreau <w@1wt•eu>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
	Thomas Petazzoni <thomas.petazzoni@free-electrons•com>,
	Gregory CLEMENT <gregory.clement@free-electrons•com>,
	Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH 0/5] Assorted mvneta fixes
Date: Mon, 13 Jan 2014 23:36:05 +0100	[thread overview]
Message-ID: <87d2jvfr1m.fsf@natisbad.org> (raw)
In-Reply-To: <20140112222233.GG16576@1wt.eu> (Willy Tarreau's message of "Sun, 12 Jan 2014 23:22:33 +0100")

Hi,

Willy Tarreau <w@1wt•eu> writes:

>> Funny enough, I spent some time this week-end trying to find the root
>> cause of some kernel freezes and panics appearing randomly after some GB
>> read on a ReadyNAS 102 configured as a NFS server. 
>> 
>> I tested your fixes and performance series together on top of current
>> 3.13.0-rc7 and I am now unable to reproduce the freeze and panics after
>> having read more than the 300GB of traffic from the NAS: following
>> bandwith with a bwm-ng shows the rate is also far more stable than w/
>> previous driver logic (55MB/sec). So, FWIW:
>> 
>> Tested-by: Arnaud Ebalard <arno@natisbad•org>
>
> Thanks for this.
>
> BTW, the "performance" series is not supposed to fix anything, 

I was lazy and wanted to give the whole set a try in a single pass.


> and still it seems difficult to me to find what patch might have fixed
> your problem. Maybe the timer used in place of an IRQ has an even
> worse effect than what we could imagine ?

I guess so.


>> Willy, I can extend the test to RN2120 if you think it is useful to also
>> do additional tests on a dual-core armada XP.
>
> It's up to you. These patches have run extensively on my Mirabox (Armada370),
> OpenBlocks AX3 (ArmadaXP dual core) and the XP-GP board (ArmadaXP quad core),
> and fixed the stability issues and performance issues I was facing there. But
> you may be interested in testing them with your workloads (none of my boxes
> is used as an NFS server, NAS or whatever, they mainly see HTTP and very small
> packets used in stress tests).

Well, I spent the evening on my RN104 (Aramda370 w/ 2 GbE ifaces) and my
RN2120 (Dual core ArmadaXP w/ 2GbE ifaces) using one as a router and
serving NFS traffic from the other (and then changing roles). I passed
hundreds of GB of TCP/NFS traffic and did not see any issue.

Additionally, FWIW, testing both using netperf show they easily support
routing traffic w/ line rate perf.

Regarding the patches, the problem they solve impacts all Armada boards
(370 and XP) which are used for network tasks. I think it would be nice
to have those backported to stable. I can commit to do the tests of the
backports both on XP and 370 hardware down to 3.12 or 3.11 kernel if it
can help. 

Cheers,

a+

  reply	other threads:[~2014-01-13 22:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12  9:31 [PATCH 0/5] Assorted mvneta fixes Willy Tarreau
2014-01-12  9:31 ` [PATCH 1/5] net: mvneta: increase the 64-bit rx/tx stats out of the hot path Willy Tarreau
2014-01-13  0:49   ` Eric Dumazet
2014-01-13  3:06     ` Willy Tarreau
2014-01-12  9:31 ` [PATCH 2/5] net: mvneta: use per_cpu stats to fix an SMP lock up Willy Tarreau
2014-01-12 18:07   ` Eric Dumazet
2014-01-12 22:09     ` Willy Tarreau
2014-01-13  0:45       ` Eric Dumazet
2014-01-13  3:02         ` Willy Tarreau
2014-01-13  0:48   ` Eric Dumazet
2014-01-12  9:31 ` [PATCH 3/5] net: mvneta: do not schedule in mvneta_tx_timeout Willy Tarreau
2014-01-12 16:49   ` Ben Hutchings
2014-01-12 16:55     ` Willy Tarreau
2014-01-12 17:38       ` Ben Hutchings
2014-01-12 22:14         ` Willy Tarreau
2014-01-14 15:33         ` Willy Tarreau
2014-01-12  9:31 ` [PATCH 4/5] net: mvneta: add missing bit descriptions for interrupt masks and causes Willy Tarreau
2014-01-12  9:31 ` [PATCH 5/5] net: mvneta: replace Tx timer with a real interrupt Willy Tarreau
2014-01-13 23:22   ` Arnaud Ebalard
2014-01-14  7:30     ` Willy Tarreau
2014-01-12 19:21 ` [PATCH 0/5] Assorted mvneta fixes Arnaud Ebalard
2014-01-12 22:22   ` Willy Tarreau
2014-01-13 22:36     ` Arnaud Ebalard [this message]
2014-01-14  7:24       ` Willy Tarreau
2014-01-15  0:58 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2jvfr1m.fsf@natisbad.org \
    --to=arno@natisbad$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=gregory.clement@free-electrons$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=thomas.petazzoni@free-electrons$(echo .)com \
    --cc=w@1wt$(echo .)eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox