Subject: Re: [PATCH bpf-next v2 0/8] Improve XDP samples usability and output

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Fri, 23 Jul 2021 23:32:13 +0200

Kumar Kartikeya Dwivedi <[email-masked]> writes:

> This set revamps XDP samples related to redirection to show better output and
> implement missing features consolidating all their differences and giving them a
> consistent look and feel, by implementing common features and command line
> options.  Some of the TODO items like reporting redirect error numbers
> (ENETDOWN, EINVAL, ENOSPC, etc.) have also been implemented.
>
> Some of the features are:
> * Received packet statistics
> * xdp_redirect/xdp_redirect_map tracepoint statistics
> * xdp_redirect_err/xdp_redirect_map_err tracepoint statistics (with support for
>   showing exact errno)
> * xdp_cpumap_enqueue/xdp_cpumap_kthread tracepoint statistics
> * xdp_devmap_xmit tracepoint statistics
> * xdp_exception tracepoint statistics
> * Per ifindex pair devmap_xmit stats shown dynamically (for xdp_monitor) to
>   decompose the total.
> * Use of BPF skeleton and BPF static linking to share BPF programs.
> * Use of vmlinux.h and tp_btf for raw_tracepoint support.
> * Removal of redundant -N/--native-mode option (enforced by default now)
> * ... and massive cleanups all over the place.

I took this for a quick spin, and it's a great improvement over the
status quo; it's not immediately obvious when using xdp_redirect and it
doesn't work, and the stats output is awesome!

Today is my last day before going on vacation for three weeks, and
unfortunately I won't have time to review the code in detail before
then; but wanted to express some encouragement before signing off -
please keep at this! :)

-Toke