Subject: Re: [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules

From: Vinicius Costa Gomes <[email-masked]>
Date: Wed, 29 Jan 2020 10:13:22 -0800

David Miller <[email-masked]> writes:

> From: Vinicius Costa Gomes <[email-masked]>
> Date: Tue, 28 Jan 2020 15:52:26 -0800
>
>> When any offload mode is enabled, users had to specify the
>> "flags" parameter when adding a new "admin" schedule.
>> 
>> This fix allows that parameter to be omitted when adding a new
>> schedule.
>> 
>> This will make that we have one source of truth for 'flags'.
>> 
>> Fixes: 4cfd5779bd6e ("taprio: Add support for txtime-assist mode")
>> Signed-off-by: Vinicius Costa Gomes <[email-masked]>
>> Acked-by: Vladimir Oltean <[email-masked]>
>
> This will visibly change behavior for a feature in a released
> kernel (v5.3 and later) and it means that newer tools will do
> things that don't work in older kernels.
>
> I think your opportunity to adjust these semantics, has therefore,
> long passed.

Understood. Another lesson learned.

I'll need to send another version then. This semantic change have
creeped up to the "rcu stall" fix.

Cheers,
--
Vinicius