Subject: Re: [patch iproute2 1/2] devlink: introduce cmdline option to switch to a different namespace

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Sat, 27 Jul 2019 12:12:48 +0200

Jiri Pirko <[email-masked]> writes:

> From: Jiri Pirko <[email-masked]>
>
> Signed-off-by: Jiri Pirko <[email-masked]>
> ---
>  devlink/devlink.c  | 12 ++++++++++--
>  man/man8/devlink.8 |  4 ++++
>  2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index d8197ea3a478..9242cc05ad0c 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -32,6 +32,7 @@
>  #include "mnlg.h"
>  #include "json_writer.h"
>  #include "utils.h"
> +#include "namespace.h"
>  
>  #define ESWITCH_MODE_LEGACY "legacy"
>  #define ESWITCH_MODE_SWITCHDEV "switchdev"
> @@ -6332,7 +6333,7 @@ static int cmd_health(struct dl *dl)
>  static void help(void)
>  {
>  	pr_err("Usage: devlink [ OPTIONS ] OBJECT { COMMAND | help }\n"
> -	       "       devlink [ -f[orce] ] -b[atch] filename\n"
> +	       "       devlink [ -f[orce] ] -b[atch] filename -N[etns]
>  netnsname\n"

'ip' uses lower-case n for this; why not be consistent?

-Toke