public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: David Miller <davem@davemloft•net>,
	netdev <netdev@vger•kernel.org>,
	Florian Fainelli <f.fainelli@gmail•com>
Subject: Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent
Date: Sun, 13 Mar 2016 14:48:02 -0400	[thread overview]
Message-ID: <87egbe1afx.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160313155131.GE9674@lunn.ch>

Hi Andrew,

Andrew Lunn <andrew@lunn•ch> writes:

> On Sun, Mar 13, 2016 at 03:10:13AM -0400, Vivien Didelot wrote:
>> Andrew Lunn <andrew@lunn•ch> writes:
>> 
>> > All the drivers support multiple chips, but mv88e6123_61_65 is the
>> > only one that reflects this in its naming. Change it to be consistent
>> > with the other drivers.
>> >
>> > Signed-off-by: Andrew Lunn <andrew@lunn•ch>
>> 
>> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
>> 
>> When mv88e6xxx will become a driver by its own supporting different
>> devices, it'll be good to rename it to a reference driver as well, say
>> mv88e6352.

Ha, good to know, I didn't know about such convention. I like that.

> In device tree land, the convention is to use the lowest version
> number supported. So it will probably be called mv88e6085.c.
>
>> 
>> > diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c
>> > new file mode 100644
>> > index 000000000000..69a6f79dcb10
>> > --- /dev/null
>> > +++ b/drivers/net/dsa/mv88e6123.c
>> > @@ -0,0 +1,124 @@
>> 
>> Note that to avoid the big diff above, you can use the -M option of
>> git-format-patch to detect file renames.
>
> Yes, i always forget that. I wounder why it is not turned on by
> default? Maybe older versions of patch do not understand it?

I'm not sure neither. Hopefully it is now supported by git show, diff,
format-patch and send-email subcommands.

Thanks,
Vivien

next prev parent reply	other threads:[~2016-03-13 18:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 23:01 [PATCH net-next 0/5] DSA cleanup and fixes Andrew Lunn
2016-03-11 23:01 ` [PATCH net-next 1/5] dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent Andrew Lunn
2016-03-13  7:10   ` Vivien Didelot
2016-03-13 15:51     ` Andrew Lunn
2016-03-13 18:48       ` Vivien Didelot [this message]
2016-03-11 23:01 ` [PATCH net-next 2/5] dsa: slave: Don't reference NULL pointer during phy_disconnect Andrew Lunn
2016-03-11 23:01 ` [PATCH net-next 3/5] dsa: Destroy fixed link phys after the phy has been disconnected Andrew Lunn
2016-03-11 23:01 ` [PATCH net-next 4/5] dsa: dsa: Fix freeing of fixed-phys from user ports Andrew Lunn
2016-03-11 23:01 ` [PATCH net-next 5/5] phy: fixed: Fix removal of phys Andrew Lunn
2016-03-11 23:18   ` Florian Fainelli
2016-03-12 17:24     ` Andrew Lunn
2016-03-14 19:44 ` [PATCH net-next 0/5] DSA cleanup and fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egbe1afx.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=f.fainelli@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox