* [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port
@ 2015-12-14 10:05 Andrzej Hajda
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
2015-12-15 9:09 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Or Gerlitz
0 siblings, 2 replies; 5+ messages in thread
From: Andrzej Hajda @ 2015-12-14 10:05 UTC (permalink / raw)
To: Or Gerlitz, Jack Morgenstein
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
David S. Miller, Eran Ben Elisha, Hadar Hen Zion, Moni Shoua,
Yishai Hadas, Maor Gottlieb, netdev, linux-kernel
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
---
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
index da7f578..b46dbe2 100644
--- a/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
+++ b/drivers/net/ethernet/mellanox/mlx4/resource_tracker.c
@@ -4331,9 +4331,10 @@ int mlx4_QP_FLOW_STEERING_ATTACH_wrapper(struct mlx4_dev *dev, int slave,
return -EOPNOTSUPP;
ctrl = (struct mlx4_net_trans_rule_hw_ctrl *)inbox->buf;
- ctrl->port = mlx4_slave_convert_port(dev, slave, ctrl->port);
- if (ctrl->port <= 0)
+ err = mlx4_slave_convert_port(dev, slave, ctrl->port);
+ if (err <= 0)
return -EINVAL;
+ ctrl->port = err;
qpn = be32_to_cpu(ctrl->qpn) & 0xffffff;
err = get_res(dev, slave, qpn, RES_QP, &rqp);
if (err) {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
2015-12-14 10:05 [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Andrzej Hajda
@ 2015-12-14 10:06 ` Andrzej Hajda
[not found] ` <1450087564-28441-4-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-12-15 9:09 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Or Gerlitz
1 sibling, 1 reply; 5+ messages in thread
From: Andrzej Hajda @ 2015-12-14 10:06 UTC (permalink / raw)
To: QCA ath9k Development
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Kalle Valo, linux-wireless, ath9k-devel, netdev, linux-kernel
The function can return negative values in case of error.
Its result should be then tested for such case.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
---
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index a680a97..fe1fd1a 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -834,7 +834,7 @@ void ath9k_htc_ani_work(struct work_struct *work)
if (longcal || shortcal)
common->ani.caldone =
ath9k_hw_calibrate(ah, ah->curchan,
- ah->rxchainmask, longcal);
+ ah->rxchainmask, longcal) > 0;
ath9k_htc_ps_restore(priv);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port
2015-12-14 10:05 [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Andrzej Hajda
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
@ 2015-12-15 9:09 ` Or Gerlitz
2015-12-15 16:55 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Or Gerlitz @ 2015-12-15 9:09 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Jack Morgenstein, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
David S. Miller, Eran Ben Elisha, Hadar Hen Zion, Moni Shoua,
Yishai Hadas, Maor Gottlieb, netdev, linux-kernel
On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
Please add here
Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')
> Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
otherwise, Looks good
Acked-by: Or Gerlitz <ogerlitz@mellanox•com>
Or.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port
2015-12-15 9:09 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Or Gerlitz
@ 2015-12-15 16:55 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2015-12-15 16:55 UTC (permalink / raw)
To: ogerlitz
Cc: a.hajda, jackm, b.zolnierkie, m.szyprowski, eranbe, hadarh, monis,
yishaih, maorg, netdev, linux-kernel
From: Or Gerlitz <ogerlitz@mellanox•com>
Date: Tue, 15 Dec 2015 11:09:40 +0200
> On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
>> The function can return negative values, so its result should
>> be assigned to signed variable.
>>
>> The problem has been detected using proposed semantic patch
>> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>>
>> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>>
>
> Please add here
>
> Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')
>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
>
> otherwise, Looks good
>
> Acked-by: Or Gerlitz <ogerlitz@mellanox•com>
Applied with Fixes tag added.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-31 13:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 10:05 [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Andrzej Hajda
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
[not found] ` <1450087564-28441-4-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-12-31 13:12 ` Kalle Valo
2015-12-15 9:09 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Or Gerlitz
2015-12-15 16:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox