From: Kalle Valo <kvalo@kernel•org>
To: Breno Leitao <leitao@debian•org>
Cc: aleksander.lobakin@intel•com, kuba@kernel•org,
davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
elder@kernel•org, linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org, nbd@nbd•name,
sean.wang@mediatek•com, Mark-MC.Lee@mediatek•com,
lorenzo@kernel•org, taras.chornyi@plvision•eu,
ath11k@lists•infradead.org, ath10k@lists•infradead.org,
linux-wireless@vger•kernel.org, geomatsi@gmail•com,
Matthias Brugger <matthias.bgg@gmail•com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
quic_jjohnson@quicinc•com, leon@kernel•org,
dennis.dalessandro@cornelisnetworks•com,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
bpf@vger•kernel.org, idosch@idosch•org
Subject: Re: [PATCH net-next v5 00/10] allocate dummy device dynamically
Date: Thu, 11 Apr 2024 11:38:45 +0300 [thread overview]
Message-ID: <87frvsz42y.fsf@kernel.org> (raw)
In-Reply-To: <20240410131407.3897251-1-leitao@debian.org> (Breno Leitao's message of "Wed, 10 Apr 2024 06:13:41 -0700")
Breno Leitao <leitao@debian•org> writes:
> struct net_device shouldn't be embedded into any structure, instead,
> the owner should use the private space to embed their state into
> net_device.
>
> But, in some cases the net_device is embedded inside the private
> structure, which blocks the usage of zero-length arrays inside
> net_device.
>
> Create a helper to allocate a dummy device at dynamically runtime, and
> move the Ethernet devices to use it, instead of embedding the dummy
> device inside the private structure.
>
> This fixes all the network cases plus some wireless drivers.
>
> PS: Due to lack of hardware, unfortunately most these patches are
> compiled tested only, except ath11k that was kindly tested by Kalle Valo.
>
> ---
> Changelog:
>
> v1:
> * https://lore.kernel.org/all/20240327200809.512867-1-leitao@debian.org/
>
> v2:
> * Patch 1: Use a pre-defined name ("dummy#") for the dummy
> net_devices.
> * Patch 2-5: Added users for the new helper.
> v3:
> * Use free_netdev() instead of kfree() as suggested by Jakub.
> * Change the free_netdev() place in ipa driver, as suggested by
> Alex Elder.
> * Set err in the error path in the Marvell driver, as suggested
> by Simon Horman.
> v4:
> * Added a new patch to add dummy device at free_netdev(), as suggested
> by Jakub.
> * Added support for some wireless driver.
> * Added some Acked-by and Reviewed-by.
> v5:
> * Added a new patch to fix some typos in the previous code,
> suggested by Ido.
> * Rebased to net-net/main
I'm nitpicking here but I prefer to have the changelog in reverse order,
that is v5 first and v1 last. I'm most interested about the changes in
v5, I don't care about v1 at this point. Though I don't know if net
folks have a different prefence, just wanted to mention this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-11 8:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 13:13 [PATCH net-next v5 00/10] allocate dummy device dynamically Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 01/10] net: core: Fix documentation Breno Leitao
2024-04-10 15:03 ` Ido Schimmel
2024-04-10 13:13 ` [PATCH net-next v5 02/10] net: free_netdev: exit earlier if dummy Breno Leitao
2024-04-10 15:05 ` Ido Schimmel
2024-04-10 13:13 ` [PATCH net-next v5 03/10] net: create a dummy net_device allocator Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 04/10] net: marvell: prestera: allocate dummy net_device dynamically Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 05/10] net: mediatek: mtk_eth_sock: " Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 06/10] net: ipa: " Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 07/10] net: ibm/emac: " Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 08/10] wifi: qtnfmac: Use netdev dummy allocator helper Breno Leitao
2024-04-10 13:13 ` [PATCH net-next v5 09/10] wifi: ath10k: allocate dummy net_device dynamically Breno Leitao
2024-04-11 8:38 ` Kalle Valo [this message]
2024-04-11 13:09 ` [PATCH net-next v5 00/10] allocate dummy device dynamically Jakub Kicinski
2024-04-11 13:41 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frvsz42y.fsf@kernel.org \
--to=kvalo@kernel$(echo .)org \
--cc=Mark-MC.Lee@mediatek$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=ath10k@lists$(echo .)infradead.org \
--cc=ath11k@lists$(echo .)infradead.org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=dennis.dalessandro@cornelisnetworks$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=elder@kernel$(echo .)org \
--cc=geomatsi@gmail$(echo .)com \
--cc=idosch@idosch$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leitao@debian$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=quic_jjohnson@quicinc$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=taras.chornyi@plvision$(echo .)eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox