From: Petr Machata <petrm@nvidia•com>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: <netdev@vger•kernel.org>, "David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>, Shuah Khan <shuah@kernel•org>,
David Ahern <dsahern@kernel•org>,
Petr Machata <petrm@mellanox•com>
Subject: Re: [PATCH net] selftests: forwarding: lib: quote the sysctl values
Date: Wed, 8 Feb 2023 12:30:52 +0100 [thread overview]
Message-ID: <87fsbgcrz1.fsf@nvidia.com> (raw)
In-Reply-To: <20230208032110.879205-1-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail•com> writes:
> When set/restore sysctl value, we should quote the value as some keys
> may have multi values, e.g. net.ipv4.ping_group_range
>
> Fixes: f5ae57784ba8 ("selftests: forwarding: lib: Add sysctl_set(), sysctl_restore()")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail•com>
Yep, makes sense.
Reviewed-by: Petr Machata <petrm@nvidia•com>
next prev parent reply other threads:[~2023-02-08 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 3:21 [PATCH net] selftests: forwarding: lib: quote the sysctl values Hangbin Liu
2023-02-08 11:30 ` Petr Machata [this message]
2023-02-09 10:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbgcrz1.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@mellanox$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox