Subject: Re: [PATCH net-next v2 2/2] net: tcp: add skb drop reasons to route_req()

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Thu, 28 Apr 2022 15:22:04 +0200

[email-masked] writes:

> From: Menglong Dong <[email-masked]>
>
> Add skb drop reasons to the route_req() in struct tcp_request_sock_ops.
> Following functions are involved:
>
>   tcp_v4_route_req()
>   tcp_v6_route_req()
>   subflow_v4_route_req()
>   subflow_v6_route_req()
>
> And the new reason SKB_DROP_REASON_SECURITY is added, which is used when
> skb is dropped by LSM.

Could we maybe pick a slightly less generic name? If I saw
"SKB_DROP_REASON_SECURITY" my first thought would be something related
to *network* security, like a firewall. Maybe just SKB_DROP_REASON_LSM?

-Toke