From: Kurt Kanzenbach <kurt@linutronix•de>
To: Alexander Duyck <alexander.duyck@gmail•com>,
Jesper Dangaard Brouer <brouer@redhat•com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
John Fastabend <john.fastabend@gmail•com>,
Sven Auhagen <sven.auhagen@voleatech•de>,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
bpf@vger•kernel.org,
Ilias Apalodimas <ilias.apalodimas@linaro•org>,
Lorenzo Bianconi <lorenzo@kernel•org>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>
Subject: Re: [PATCH RFC net] igb: Fix XDP with PTP enabled
Date: Tue, 13 Apr 2021 19:21:00 +0200 [thread overview]
Message-ID: <87fszuyubn.fsf@kurt> (raw)
In-Reply-To: <CAKgT0UekqPNQxV6PzpEeis69z3e3YNcaFyot=nD7w26hLxPX2Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Tue Apr 13 2021, Alexander Duyck wrote:
> On Mon, Apr 12, 2021 at 7:29 AM Jesper Dangaard Brouer
> <brouer@redhat•com> wrote:
>> > +ktime_t igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va)
>> > {
>> > struct igb_adapter *adapter = q_vector->adapter;
>> > + struct skb_shared_hwtstamps ts;
>> > __le64 *regval = (__le64 *)va;
>> > int adjust = 0;
>> >
>> > if (!(adapter->ptp_flags & IGB_PTP_ENABLED))
>> > - return IGB_RET_PTP_DISABLED;
>> > + return 0;
>> >
>> > /* The timestamp is recorded in little endian format.
>> > * DWORD: 0 1 2 3
>> > @@ -888,10 +887,9 @@ int igb_ptp_rx_pktstamp(struct igb_q_vector *q_vector, void *va,
>> >
>> > /* check reserved dwords are zero, be/le doesn't matter for zero */
>> > if (regval[0])
>> > - return IGB_RET_PTP_INVALID;
>> > + return 0;
>> >
>
> One thing that needs to be cleaned up in the patch is that if it is
> going to drop these return values it should probably drop the defines
> for them since I don't think they are used anywhere else.
Yes, of course. I'll clean it up before sending a non RFC version.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2021-04-13 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 10:17 [PATCH RFC net] igb: Fix XDP with PTP enabled Kurt Kanzenbach
2021-04-12 14:28 ` Jesper Dangaard Brouer
2021-04-13 7:34 ` Kurt Kanzenbach
2021-04-13 15:25 ` Alexander Duyck
2021-04-13 17:21 ` Kurt Kanzenbach [this message]
2021-06-02 10:49 ` [Intel-wired-lan] " Penigalapati, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fszuyubn.fsf@kurt \
--to=kurt@linutronix$(echo .)de \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lorenzo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sven.auhagen@voleatech$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox