From: Daniel Axtens <dja@axtens•net>
To: Dmitry Vyukov <dvyukov@google•com>
Cc: Paolo Abeni <pabeni@redhat•com>,
David Miller <davem@davemloft•net>,
syzkaller-bugs@googlegroups•com, netdev <netdev@vger•kernel.org>,
Florian Westphal <fw@strlen•de>
Subject: Re: syzcaller patch postings...
Date: Fri, 23 Feb 2018 01:16:17 +1100 [thread overview]
Message-ID: <87fu5thzym.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <CACT4Y+YXPjTyW52Kjq7L6fJdT4ypnboRq0rS=yZ857NseSUPQg@mail.gmail.com>
Dmitry Vyukov <dvyukov@google•com> writes:
> On Thu, Feb 22, 2018 at 2:31 PM, Daniel Axtens <dja@axtens•net> wrote:
>> Dmitry Vyukov <dvyukov@google•com> writes:
>>
>>> On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni <pabeni@redhat•com> wrote:
>>>> On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote:
>>>>> I have to mention this now before it gets out of control.
>>>>>
>>>>> I would like to ask that syzkaller stop posting the patch it is
>>>>> testing when it posts to netdev.
>>>>
>>>> There is an open issue on this topic:
>>>>
>>>> https://github.com/google/syzkaller/issues/526
>>>>
>>>> The current behaviour is that syzbot replies to all get_maintainer.pl
>>>> recipients after testing a patch, regardless of the test submission
>>>> recipient list, the idea was instead to respect such list.
>>>
>>>
>>> Hi David, Florian, Paolo,
>>>
>>> Didn't realize it triggers patchwork. This wasn't intentional, sorry.
>>
>> A little-publicised and incorrectly-documented(!) feature of Patchwork
>> is that it supports some email headers. In particular, if you include an
>> "X-Patchwork-Hint: ignore" header, the mail will not be parsed by
>> Patchwork.
>>
>> This will stop it being recorded as a patch. Unfortunately it will also
>> stop it being recorded as a comment - I don't know if that's an issue in
>> this case. Maybe we can set you up with Patchwork 2's new checks
>> infrastructure instead.
>
> Nice. But unfortunately the current mailing technology we use allows
> very limited set of headers and no custom headers:
> https://cloud.google.com/appengine/docs/standard/go/mail/mail-with-headers-attachments
> So while possible, it would require very significant rework...
Ah, oh well, nevermind.
> What's the Patchwork 2's new checks infrastructure?
<puts on patchwork maintainer hat>
It's probably more a long-term thing than an immediate fix, but...
The checks API is designed to integrate reporting of CI/testing results
into Patchwork. It allows - through a REST API - an arbitrary process
(like your checking) to report success/warning/failure against a
patch. In your case you could report success = patch prevents bug, and
failure = bug still exists with patch. It's still slightly a
work-in-progress: at the moment you need an API key from a maintainer to
post checks. But it does look pretty in the web frontend:
e.g. https://patchwork.ozlabs.org/patch/871346/ - and the number of
successful/warning/failed tests shows up on the patch list page.
There's currently only one project (that I know of) out there that uses
the checks API - Snowpatch: https://github.com/ruscur/snowpatch
If, at any point in the future, you want to explore this, let me know as
I'd be *very* happy to help with the implementation and if needed push
features into Patchwork that make it easier/better.
</hat>
> If it will still remain a problem (hopefully not), then maybe it's
> possible to blacklist syzbot address from creating new patches. syzbot
> can do a lot, but so far does not also generate fixes for the bugs it
> discovers :)
In immediate practical terms, that might be the easiest. They all come
from the same email address, right?
Regards,
Daniel
next prev parent reply other threads:[~2018-02-22 14:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 21:47 syzcaller patch postings David Miller
2018-02-21 21:52 ` Florian Westphal
2018-02-22 8:26 ` Paolo Abeni
2018-02-22 9:58 ` Dmitry Vyukov
2018-02-22 10:03 ` Florian Westphal
2018-02-22 12:59 ` Dmitry Vyukov
2018-02-22 13:31 ` Daniel Axtens
2018-02-22 13:54 ` Dmitry Vyukov
2018-02-22 14:16 ` Daniel Axtens [this message]
2018-02-22 14:39 ` Dmitry Vyukov
2018-02-22 14:35 ` David Miller
2018-02-22 14:46 ` Dmitry Vyukov
2018-02-22 15:09 ` Daniel Axtens
2018-02-23 10:30 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu5thzym.fsf@linkitivity.dja.id.au \
--to=dja@axtens$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dvyukov@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=syzkaller-bugs@googlegroups$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox