Subject: Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

From: Vitaly Kuznetsov <[email-masked]>
Date: Fri, 17 Jul 2015 17:04:10 +0200

Dexuan Cui <[email-masked]> writes:

>> From: David Miller
>> Sent: Thursday, July 16, 2015 12:19
>> 
>> From: Dexuan Cui
>> Date: Tue, 14 Jul 2015 03:00:48 -0700
>> 
>> > +	pr_debug("hvsock_sk_destruct: called\n");
>> 
>> Debug logging just to state that a function is called is not appropriate,
>> we have very sophisticated tracing facilities in the kernel that can do
>> that transparently, and more.
>> 
>> Please remove this.
> OK. 
>
>> > +	if (hvsk->channel) {
>> > +		pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
>> 
>> Likewise, these kinds of debug logs are totally inappropriate.
> OK, I'll remove all the pr_debug() in the patch.
>

I'd suggest we rather use something like net_dbg_ratelimited()
intead. The driver is new so issues are expected. Some debugging may
be useful)

[...]

-- 
  Vitaly