From: ebiederm@xmission•com (Eric W. Biederman)
To: David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, alexander.h.duyck@intel•com, jhs@mojatatu•com
Subject: [PATCH 0/2] net_sched: Remove broken tc actions
Date: Sun, 27 Oct 2013 06:40:54 -0700 [thread overview]
Message-ID: <87fvrmu909.fsf@xmission.com> (raw)
While auditing the code to make certain it would be safe to enable the
user namespace root to use tc actions I stumbled on the strange fact
that two of the tc modules in the kernel have been broken for more
years than I care to think about.
In particular neither of these two modules implements the tc_action_ops
lookup method. Which means that in practice neither RTM_GETACTION nor
RTM_DELACTION work. And with RTM_DELACTION broken that looks like a
permanent leak of kernel memory to me.
A leak I am not happy at root having and certainly not something I want
to allow unprivileged users access to.
On the premise that 5+ years is too long to wait for someone to notice,
complain and get this code fixed let's just remove these broken tc
modules.
Eric W. Biederman (2):
net_sched: Remove broken act_skbedit
net_sched: Remove broken act_simple
include/net/tc_act/tc_defact.h | 14 --
include/net/tc_act/tc_skbedit.h | 36 -----
include/uapi/linux/tc_act/Kbuild | 2 -
include/uapi/linux/tc_act/tc_defact.h | 19 ---
include/uapi/linux/tc_act/tc_skbedit.h | 46 -------
net/sched/Kconfig | 25 ----
net/sched/Makefile | 2 -
net/sched/act_simple.c | 225 --------------------------------
net/sched/act_skbedit.c | 224 -------------------------------
9 files changed, 0 insertions(+), 593 deletions(-)
next reply other threads:[~2013-10-27 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 13:40 Eric W. Biederman [this message]
2013-10-27 13:42 ` [PATCH 1/2] net_sched: Remove broken act_skbedit Eric W. Biederman
2013-10-27 13:43 ` [PATCH 2/2] net_sched: Remove broken act_simple Eric W. Biederman
2013-10-27 16:58 ` [PATCH 0/2] net_sched: Remove broken tc actions Jamal Hadi Salim
2013-10-27 20:37 ` Alexander Duyck
2013-10-28 22:57 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvrmu909.fsf@xmission.com \
--to=ebiederm@xmission$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox