From: "Bjørn Mork" <bjorn@mork•no>
To: <Narendra_K@Dell•com>
Cc: <netdev@vger•kernel.org>, <bhutchings@solarflare•com>
Subject: Re: [RFC PATCH] Initialize dev_id sysfs attribute to -1 by default
Date: Thu, 30 May 2013 15:38:46 +0200 [thread overview]
Message-ID: <87fvx4mvtl.fsf@nemi.mork.no> (raw)
In-Reply-To: <20130530132419.GA1368@fedora-17-guest.blr.amer.dell.com> (Narendra K.'s message of "Thu, 30 May 2013 18:55:47 +0530")
<Narendra_K@Dell•com> writes:
> From: Narendra K <narendra_k@dell•com>
>
> 'dev_id' sysfs attribute is initialized to zero by default.
> It is also zero based. This creates ambiguity in differentiating
> whether the driver set it to zero or it is the default value.
> Initialize 'dev_id' to -1 to make the scenario unambiguous.
I understand your concern, but I don't think you can do this. It
changes the userspace API, and has some very visible side effects.
Please take a look at net/ipv6/addrconf.c
Bjørn
next prev parent reply other threads:[~2013-05-30 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 13:25 [RFC PATCH] Initialize dev_id sysfs attribute to -1 by default Narendra_K
2013-05-30 13:38 ` Bjørn Mork [this message]
2013-05-31 12:17 ` Narendra_K
2013-06-07 14:45 ` John Fastabend
2013-06-07 15:23 ` Ben Hutchings
2013-06-07 17:15 ` John Fastabend
2013-06-10 18:11 ` Narendra_K
2013-06-10 18:43 ` John Fastabend
2013-06-07 17:02 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvx4mvtl.fsf@nemi.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=Narendra_K@Dell$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox