From: Petr Machata <petrm@nvidia•com>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel•org>
Cc: <mptcp@lists•linux.dev>, "David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>, Shuah Khan <shuah@kernel•org>,
Mat Martineau <martineau@kernel•org>,
Geliang Tang <geliang@kernel•org>,
Pablo Neira Ayuso <pablo@netfilter•org>,
"Jozsef Kadlecsik" <kadlec@netfilter•org>,
Petr Machata <petrm@nvidia•com>, <netdev@vger•kernel.org>,
<linux-kselftest@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<netfilter-devel@vger•kernel.org>, <coreteam@netfilter•org>
Subject: Re: [PATCH net-next] selftests: net: include lib/sh/*.sh with lib.sh
Date: Mon, 4 Nov 2024 15:00:03 +0100 [thread overview]
Message-ID: <87h68nksfw.fsf@nvidia.com> (raw)
In-Reply-To: <20241104-net-next-selftests-lib-sh-deps-v1-1-7c9f7d939fc2@kernel.org>
"Matthieu Baerts (NGI0)" <matttbe@kernel•org> writes:
> Recently, the net/lib.sh file has been modified to include defer.sh from
> net/lib/sh/ directory. The Makefile from net/lib has been modified
> accordingly, but not the ones from the sub-targets using net/lib.sh.
>
> Because of that, the new file is not installed as expected when
> installing the Forwarding, MPTCP, and Netfilter targets, e.g.
>
> # make -C tools/testing/selftests TARGETS=net/mptcp install \
> INSTALL_PATH=/tmp/kself
> # cd /tmp/kself/
> # ./run_kselftest.sh -c net/mptcp
> TAP version 13
> 1..7
> # timeout set to 1800
> # selftests: net/mptcp: mptcp_connect.sh
> # ./../lib.sh: line 5: /tmp/kself/net/lib/sh/defer.sh: No such file
> or directory
> # (...)
>
> This can be fixed simply by adding all the .sh files from net/lib/sh
> directory to the TEST_INCLUDES variable in the different Makefile's.
>
> Fixes: a6e263f125cd ("selftests: net: lib: Introduce deferred commands")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel•org>
Gah, I knew moving this to a separate module would end up biting us.
Well, hopefully the wildcard takes care of this once and for all.
Thanks for the fix!
Reviewed-by: Petr Machata <petrm@nvidia•com>
next prev parent reply other threads:[~2024-11-04 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 11:34 [PATCH net-next] selftests: net: include lib/sh/*.sh with lib.sh Matthieu Baerts (NGI0)
2024-11-04 14:00 ` Petr Machata [this message]
2024-11-06 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h68nksfw.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=geliang@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=kadlec@netfilter$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=martineau@kernel$(echo .)org \
--cc=matttbe@kernel$(echo .)org \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox