From: Petr Machata <petrm@nvidia•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Petr Machata <petrm@nvidia•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, <netdev@vger•kernel.org>,
Ido Schimmel <idosch@nvidia•com>,
David Ahern <dsahern@kernel•org>, <mlxsw@nvidia•com>,
"Gustavo A . R . Silva" <gustavoars@kernel•org>,
Kees Cook <keescook@chromium•org>
Subject: Re: [PATCH net-next 7/7] net: nexthop: Expose nexthop group HW stats to user space
Date: Wed, 28 Feb 2024 18:16:22 +0100 [thread overview]
Message-ID: <87h6hso6fa.fsf@nvidia.com> (raw)
In-Reply-To: <20240227193932.7762464d@kernel.org>
Jakub Kicinski <kuba@kernel•org> writes:
> On Tue, 27 Feb 2024 19:17:32 +0100 Petr Machata wrote:
>> + if (nla_put_u32(skb, NHA_HW_STATS_ENABLE, nhg->hw_stats))
>> + goto nla_put_failure;
>> +
>> + if (op_flags & NHA_OP_FLAG_DUMP_HW_STATS &&
>> + nhg->hw_stats) {
>> + err = nh_grp_hw_stats_update(nh, &hw_stats_used);
>> + if (err)
>> + goto hw_stats_update_fail;
>> +
>> + if (nla_put_u32(skb, NHA_HW_STATS_USED, hw_stats_used))
>> + goto nla_put_failure;
>
> Something's off with the jump targets here.
> clang detects nest is not initialized and you'll try to cancel it
Yes, the nest only starts below. Will fix.
>
>> + }
>> +
>> nest = nla_nest_start(skb, NHA_GROUP_STATS);
>> if (!nest)
>> return -EMSGSIZE;
next prev parent reply other threads:[~2024-02-28 17:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 18:17 [PATCH net-next 0/7] Support for nexthop group statistics Petr Machata
2024-02-27 18:17 ` [PATCH net-next 1/7] net: nexthop: Adjust netlink policy parsing for a new attribute Petr Machata
2024-02-27 18:17 ` [PATCH net-next 2/7] net: nexthop: Add NHA_OP_FLAGS Petr Machata
2024-02-28 3:34 ` Jakub Kicinski
2024-02-28 10:50 ` Petr Machata
2024-02-28 14:48 ` Jakub Kicinski
2024-02-28 15:16 ` Jakub Kicinski
2024-02-28 15:58 ` Petr Machata
2024-02-28 16:42 ` Jakub Kicinski
2024-02-29 14:03 ` Petr Machata
2024-02-27 18:17 ` [PATCH net-next 3/7] net: nexthop: Add nexthop group entry stats Petr Machata
2024-02-28 14:30 ` Simon Horman
2024-02-28 15:57 ` Petr Machata
2024-02-27 18:17 ` [PATCH net-next 4/7] net: nexthop: Expose nexthop group stats to user space Petr Machata
2024-02-28 3:35 ` Jakub Kicinski
2024-02-28 11:24 ` Petr Machata
2024-02-27 18:17 ` [PATCH net-next 5/7] net: nexthop: Add hardware statistics notifications Petr Machata
2024-02-27 18:17 ` [PATCH net-next 6/7] net: nexthop: Add ability to enable / disable hardware statistics Petr Machata
2024-02-27 18:17 ` [PATCH net-next 7/7] net: nexthop: Expose nexthop group HW stats to user space Petr Machata
2024-02-28 3:39 ` Jakub Kicinski
2024-02-28 17:16 ` Petr Machata [this message]
2024-02-28 3:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6hso6fa.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox