Subject: Re: [net-next PATCH] octeontx2: Add PTP clock driver for Octeon PTM clock.

From: Vinicius Costa Gomes <[email-masked]>
Date: Thu, 25 Jan 2024 16:11:02 -0800

Sai Krishna <[email-masked]> writes:

> The PCIe PTM(Precision time measurement) protocol provides precise
> coordination of events across multiple components like PCIe host
> clock, PCIe EP PHC local clocks of PCIe devices. This patch adds
> support for ptp clock based PTM clock. We can use this PTP device
> to sync the PTM time with CLOCK_REALTIME or other PTP PHC
> devices using phc2sys.
>
> Signed-off-by: Sai Krishna <[email-masked]>
> Signed-off-by: Naveen Mamindlapalli <[email-masked]>
> Signed-off-by: Sunil Kovvuri Goutham <[email-masked]>
> ---

I can see that the same device id (PCI_DEVID_OCTEONTX2_PTP) is used by a
ethernet driver.

That brings me a question: why expose a different PTP chardev? In other
words, why can't you just implement .getcrosststamp() for that ethernet
device?

Cheers,
-- 
Vinicius