From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Daniel Borkmann <daniel@iogearbox•net>, Jakub Kicinski <kuba@kernel•org>
Cc: "David S. Miller" <davem@davemloft•net>,
Alexei Starovoitov <ast@kernel•org>,
Andrii Nakryiko <andriin@fb•com>, Martin KaFai Lau <kafai@fb•com>,
Song Liu <songliubraving@fb•com>, Yonghong Song <yhs@fb•com>,
John Fastabend <john.fastabend@gmail•com>,
KP Singh <kpsingh@chromium•org>,
Jesper Dangaard Brouer <hawk@kernel•org>,
"Michael S. Tsirkin" <mst@redhat•com>,
Romain Perier <romain.perier@gmail•com>,
Allen Pais <apais@linux•microsoft.com>,
Grygorii Strashko <grygorii.strashko@ti•com>,
Simon Horman <simon.horman@netronome•com>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
Lorenzo Bianconi <lorenzo@kernel•org>,
Wei Yongjun <weiyongjun1@huawei•com>,
Jiri Benc <jbenc@redhat•com>,
oss-drivers@netronome•com, linux-omap@vger•kernel.org,
netdev@vger•kernel.org, bpf@vger•kernel.org
Subject: Re: [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order
Date: Wed, 09 Dec 2020 17:35:17 +0100 [thread overview]
Message-ID: <87h7ovndiy.fsf@toke.dk> (raw)
In-Reply-To: <2263984f-68b9-c678-5cae-a26b3e96e36b@iogearbox.net>
Daniel Borkmann <daniel@iogearbox•net> writes:
> On 12/9/20 2:57 PM, Toke Høiland-Jørgensen wrote:
>> This series restores the test_offload.py selftest to working order. It seems a
>> number of subtle behavioural changes have crept into various subsystems which
>> broke test_offload.py in a number of ways. Most of these are fairly benign
>> changes where small adjustments to the test script seems to be the best fix, but
>> one is an actual kernel bug that I've observed in the wild caused by a bad
>> interaction between xdp_attachment_flags_ok() and the rework of XDP program
>> handling in the core netdev code.
>>
>> Patch 1 fixes the bug by removing xdp_attachment_flags_ok(), and the reminder of
>> the patches are adjustments to test_offload.py, including a new feature for
>> netdevsim to force a BPF verification fail. Please see the individual patches
>> for details.
>>
>> Changelog:
>>
>> v4:
>> - Accidentally truncated the Fixes: hashes in patches 3/4 to 11 chars
>> v3:
>> - Add Fixes: tags
>> v2:
>> - Replace xdp_attachment_flags_ok() with a check in dev_xdp_attach()
>> - Better packing of struct nsim_dev
>
> Applied, thanks! I took the liberty to document the prior review with 'LGTM' as
> an Ack so it's documented in the git log as well.
SGTM, thanks! :)
-Toke
prev parent reply other threads:[~2020-12-09 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 13:57 [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 1/7] xdp: remove the xdp_attachment_flags_ok() callback Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 2/7] selftests/bpf/test_offload.py: Remove check for program load flags match Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 3/7] netdevsim: Add debugfs toggle to reject BPF programs in verifier Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 4/7] selftests/bpf/test_offload.py: only check verifier log on verification fails Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 5/7] selftests/bpf/test_offload.py: fix expected case of extack messages Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 6/7] selftests/bpf/test_offload.py: reset ethtool features after failed setting Toke Høiland-Jørgensen
2020-12-09 13:57 ` [PATCH bpf v4 7/7] selftests/bpf/test_offload.py: filter bpftool internal map when counting maps Toke Høiland-Jørgensen
2020-12-09 15:40 ` [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order patchwork-bot+netdevbpf
2020-12-09 15:40 ` Daniel Borkmann
2020-12-09 16:35 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7ovndiy.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=andriin@fb$(echo .)com \
--cc=apais@linux$(echo .)microsoft.com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=grygorii.strashko@ti$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=hawk@kernel$(echo .)org \
--cc=jbenc@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
--cc=romain.perier@gmail$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
--cc=songliubraving@fb$(echo .)com \
--cc=weiyongjun1@huawei$(echo .)com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox