From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Martin Lau <kafai@fb•com>
Cc: Daniel Borkmann <daniel@iogearbox•net>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>,
"netdev\@vger.kernel.org" <netdev@vger•kernel.org>,
"bpf\@vger.kernel.org" <bpf@vger•kernel.org>
Subject: Re: [PATCH bpf] bpftool: Don't crash on missing jited insns or ksyms
Date: Tue, 10 Dec 2019 19:11:18 +0100 [thread overview]
Message-ID: <87h828giex.fsf@toke.dk> (raw)
In-Reply-To: <20191210175915.wh7njnvt2xk64ski@kafai-mbp>
Martin Lau <kafai@fb•com> writes:
> On Tue, Dec 10, 2019 at 03:30:47PM +0100, Toke Høiland-Jørgensen wrote:
>> When JIT hardening is turned on, the kernel can fail to return jited_ksyms
> JIT hardening means net.core.bpf_jit_harden?
> From the code, it happens on the bpf_dump_raw_ok() check which is
> actually "kernel.kptr_restrict" instead?
Ah, yeah, you're right. I was looking through the hardening patchset and
the bpf_jit_harden setting was the first thing I hit upon; must admit I
didn't check this too closely :)
I'll send a v2 with an updated commit message...
-Toke
prev parent reply other threads:[~2019-12-10 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 14:30 [PATCH bpf] bpftool: Don't crash on missing jited insns or ksyms Toke Høiland-Jørgensen
2019-12-10 17:59 ` Martin Lau
2019-12-10 18:11 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h828giex.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=kafai@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox