From: Vincent Bernat <vincent@bernat•im>
To: David Ahern <dsahern@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Alexey Kuznetsov <kuznet@ms2•inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6•org>,
Jiri Pirko <jiri@mellanox•com>,
netdev@vger•kernel.org
Subject: Re: [net-next v1] net: ipv6: avoid overhead when no custom FIB rules are installed
Date: Tue, 08 Aug 2017 16:50:37 +0200 [thread overview]
Message-ID: <87h8xinmf6.fsf@luffy.cx> (raw)
In-Reply-To: <66e3d00a-6788-2e86-9563-fc1424a6a250@gmail.com> (David Ahern's message of "Tue, 8 Aug 2017 08:46:23 -0600")
❦ 8 août 2017 08:46 -0600, David Ahern <dsahern@gmail•com> :
>> diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
>> index 2f29e4e33bd3..693c27ede40e 100644
>> --- a/net/ipv6/fib6_rules.c
>> +++ b/net/ipv6/fib6_rules.c
>> @@ -63,19 +63,32 @@ unsigned int fib6_rules_seq_read(struct net *net)
>> struct dst_entry *fib6_rule_lookup(struct net *net, struct flowi6 *fl6,
>> int flags, pol_lookup_t lookup)
>> {
>> - struct fib_lookup_arg arg = {
>> - .lookup_ptr = lookup,
>> - .flags = FIB_LOOKUP_NOREF,
>> - };
>> -
>> /* update flow if oif or iif point to device enslaved to l3mdev */
>> l3mdev_update_flow(net, flowi6_to_flowi(fl6));
>
> The l3mdev_update_flow can be moved to the has_custom_rules block.
> l3mdev requires FIB rules for the lookups to work, so no rules means no
> l3mdev configured.
>
> Rest looks good to me.
I suspected that it could be moved. I'll update the patch tomorrow.
--
Choose variable names that won't be confused.
- The Elements of Programming Style (Kernighan & Plauger)
next prev parent reply other threads:[~2017-08-08 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 11:51 [net-next v1] net: ipv6: avoid overhead when no custom FIB rules are installed Vincent Bernat
2017-08-08 12:51 ` Jiri Pirko
2017-08-08 14:46 ` David Ahern
2017-08-08 14:50 ` Vincent Bernat [this message]
2017-08-08 18:23 ` [PATCH net-next v2] " Vincent Bernat
2017-08-08 19:10 ` David Ahern
2017-08-09 4:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8xinmf6.fsf@luffy.cx \
--to=vincent@bernat$(echo .)im \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox