Subject: Re: [RFC PATCH v2 net-next 1/2] ppp: remove NETIF_F_NETNS_LOCAL from ppp device features.

From: [email-masked] (Eric W. Biederman)
Date: Mon, 07 Jan 2013 01:16:45 -0800

Rami Rosen <[email-masked]> writes:

> There is no need for NETIF_F_NETNS_LOCAL for ppp device; this patch
> removes it.

At least pppoe_rcv_core assumes that the ppp socket and the network
devices are all in the same network namespace.  So it looks like
NETIF_F_NETNS_LOCAL is needed.

Eric

> Signed-off-by: Rami Rosen <[email-masked]>
> ---
>  drivers/net/ppp/ppp_generic.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
> index 0b2706a..89b6fc5 100644
> --- a/drivers/net/ppp/ppp_generic.c
> +++ b/drivers/net/ppp/ppp_generic.c
> @@ -1073,7 +1073,6 @@ static void ppp_setup(struct net_device *dev)
>  	dev->tx_queue_len = 3;
>  	dev->type = ARPHRD_PPP;
>  	dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;
> -	dev->features |= NETIF_F_NETNS_LOCAL;
>  	dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
>  }