Subject: Re: [PATCH iproute2-next v2 2/4] ip: ipnexthop: Support dumping next hop group stats

From: Petr Machata <[email-masked]>
Date: Fri, 15 Mar 2024 12:15:51 +0100

Stephen Hemminger <[email-masked]> writes:

> On Thu, 14 Mar 2024 15:52:13 +0100
> Petr Machata <[email-masked]> wrote:
>
>> Next hop group stats allow verification of balancedness of a next hop
>> group. The feature was merged in kernel commit 7cf497e5a122 ("Merge branch
>> 'nexthop-group-stats'"). Add to ip the corresponding support. The
>> statistics are requested if "ip nexthop" is started with -s.
>> 
>> Signed-off-by: Petr Machata <[email-masked]>
>
> Checkpatch complains:
>
> WARNING: braces {} are not necessary for single statement blocks
> #273: FILE: ip/ipnexthop.c:568:
> +	if (show_stats) {
> +		op_flags |= NHA_OP_FLAG_DUMP_STATS;
> +	}
>
> total: 0 erro

Yes. The next patch adds more code to that branch.