From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Xuan Zhuo <xuanzhuo@linux•alibaba.com>,
netdev@vger•kernel.org, bpf@vger•kernel.org
Cc: "Björn Töpel" <bjorn@kernel•org>,
"Magnus Karlsson" <magnus.karlsson@intel•com>,
"Jonathan Lemon" <jonathan.lemon@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
"Andrii Nakryiko" <andrii@kernel•org>,
"Martin KaFai Lau" <kafai@fb•com>,
"Song Liu" <songliubraving@fb•com>, "Yonghong Song" <yhs@fb•com>,
"KP Singh" <kpsingh@kernel•org>,
"Willem de Bruijn" <willemb@google•com>,
"Xie He" <xie.he.0141@gmail•com>,
"Eric Dumazet" <edumazet@google•com>,
"John Ogness" <john.ogness@linutronix•de>,
"Wang Hai" <wanghai38@huawei•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Tanner Love" <tannerlove@google•com>,
"Eyal Birger" <eyal.birger@gmail•com>,
"Menglong Dong" <dong.menglong@zte•com.cn>
Subject: Re: [PATCH bpf-next] xsk: support AF_PACKET
Date: Fri, 28 May 2021 10:55:58 +0200 [thread overview]
Message-ID: <87im33grtt.fsf@toke.dk> (raw)
In-Reply-To: <20210528060813.49003-1-xuanzhuo@linux.alibaba.com>
Xuan Zhuo <xuanzhuo@linux•alibaba.com> writes:
> In xsk mode, users cannot use AF_PACKET(tcpdump) to observe the current
> rx/tx data packets. This feature is very important in many cases. So
> this patch allows AF_PACKET to obtain xsk packages.
You can use xdpdump to dump the packets from the XDP program before it
gets redirected into the XSK:
https://github.com/xdp-project/xdp-tools/tree/master/xdp-dump
Doens't currently work on egress, but if/when we get a proper TX hook
that should be doable as well.
Wiring up XSK to AF_PACKET sounds a bit nonsensical: XSK is already a
transport to userspace, why would you need a second one?
-Toke
next prev parent reply other threads:[~2021-05-28 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 6:08 [PATCH bpf-next] xsk: support AF_PACKET Xuan Zhuo
2021-05-28 8:27 ` kernel test robot
2021-05-28 8:34 ` kernel test robot
2021-05-28 8:55 ` Toke Høiland-Jørgensen [this message]
[not found] ` <1622192521.5931044-1-xuanzhuo@linux.alibaba.com>
2021-05-28 9:25 ` Toke Høiland-Jørgensen
2021-05-28 9:32 ` Maciej Fijalkowski
2021-05-28 9:50 ` Jesper Dangaard Brouer
2021-05-28 10:00 ` Magnus Karlsson
2021-05-28 10:22 ` Daniel Borkmann
2021-05-28 10:54 ` Toke Høiland-Jørgensen
2021-05-28 11:29 ` Daniel Borkmann
2021-05-28 12:35 ` Toke Høiland-Jørgensen
2021-05-28 12:23 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im33grtt.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bjorn@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dong.menglong@zte$(echo .)com.cn \
--cc=edumazet@google$(echo .)com \
--cc=eyal.birger@gmail$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.ogness@linutronix$(echo .)de \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=songliubraving@fb$(echo .)com \
--cc=tannerlove@google$(echo .)com \
--cc=wanghai38@huawei$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=xie.he.0141@gmail$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox