Subject: Re: [PATCH bpf-next v2 1/2] xdp: Move devmap bulk queue into struct net_device

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Wed, 15 Jan 2020 23:11:21 +0100

Jesper Dangaard Brouer <[email-masked]> writes:

> On Mon, 13 Jan 2020 19:10:55 +0100
> Toke Høiland-Jørgensen <[email-masked]> wrote:
>
>> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
>> index da9c832fc5c8..030d125c3839 100644
>> --- a/kernel/bpf/devmap.c
>> +++ b/kernel/bpf/devmap.c
> [...]
>> @@ -346,8 +340,7 @@ static int bq_xmit_all(struct xdp_bulk_queue *bq, u32 flags)
>>  out:
>>  	bq->count = 0;
>>  
>> -	trace_xdp_devmap_xmit(&obj->dtab->map, obj->idx,
>> -			      sent, drops, bq->dev_rx, dev, err);
>> +	trace_xdp_devmap_xmit(NULL, 0, sent, drops, bq->dev_rx, dev, err);
>
> Hmm ... I don't like that we lose the map_id and map_index identifier.
> This is part of our troubleshooting interface.

Hmm, I guess I can take another look at whether there's a way to avoid
that. Any ideas?

-Toke