From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Jakub Kicinski <jakub.kicinski@netronome•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org,
Jesper Dangaard Brouer <brouer@redhat•com>,
Daniel Borkmann <daniel@iogearbox•net>,
Alexei Starovoitov <ast@kernel•org>
Subject: Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions
Date: Mon, 04 Mar 2019 18:37:02 +0100 [thread overview]
Message-ID: <87imwy35j5.fsf@toke.dk> (raw)
In-Reply-To: <20190304090839.09a72330@cakuba.netronome.com>
Jakub Kicinski <jakub.kicinski@netronome•com> writes:
> On Mon, 04 Mar 2019 13:47:47 +0100, Toke Høiland-Jørgensen wrote:
>> In an earlier version I had a namespace enter/exit notifier in devmap.c
>> as well, to react to new namespaces. And that notifier has a comment
>> about avoiding calls to synchronize_rcu(). But since this version
>> doesn't actually need that, maybe I can just keep using direct calls and
>> synchronize_rcu() and avoid the callback? I'm a bit worried about adding
>> both synchronize_rcu() and cond_resched() as a possible side effect of
>> every call to bpf_prog_put(), though; so maybe it's better to move the
>> cleanup somewhere it's actually safe to call cond_resched(); what would
>> that be, a workqueue?
>
> Workqueue would be my go to.
Gotcha! Thanks :)
-Toke
prev parent reply other threads:[~2019-03-04 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 14:12 [PATCH net-next v3 0/3] xdp: Use a default map for xdp_redirect helper Toke Høiland-Jørgensen
2019-03-01 14:12 ` [PATCH net-next v3 3/3] xdp: Add devmap_idx map type for looking up devices by ifindex Toke Høiland-Jørgensen
2019-03-01 14:12 ` [PATCH net-next v3 2/3] xdp: Always use a devmap for XDP_REDIRECT to a device Toke Høiland-Jørgensen
2019-03-02 2:09 ` Jakub Kicinski
2019-03-04 11:58 ` Toke Høiland-Jørgensen
2019-03-04 17:44 ` Jakub Kicinski
2019-03-04 19:05 ` Toke Høiland-Jørgensen
2019-03-04 22:15 ` Jakub Kicinski
2019-03-04 22:28 ` Toke Høiland-Jørgensen
2019-03-04 22:49 ` Jakub Kicinski
2019-03-05 9:53 ` Toke Høiland-Jørgensen
2019-03-01 14:12 ` [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions Toke Høiland-Jørgensen
2019-03-02 1:08 ` Jakub Kicinski
2019-03-04 12:47 ` Toke Høiland-Jørgensen
2019-03-04 17:08 ` Jakub Kicinski
2019-03-04 17:37 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imwy35j5.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox