From: Jiong Wang <jiong.wang@netronome•com>
To: Jiong Wang <jiong.wang@netronome•com>
Cc: ast@kernel•org, daniel@iogearbox•net, netdev@vger•kernel.org,
oss-drivers@netronome•com
Subject: Re: [PATCH bpf-next v2 08/16] bpf: functional and min/max reasoning unit tests for JMP32
Date: Wed, 23 Jan 2019 14:29:33 +0000 [thread overview]
Message-ID: <87imyfa1ma.fsf@netronome.com> (raw)
In-Reply-To: <1548076553-31268-9-git-send-email-jiong.wang@netronome.com>
Jiong Wang writes:
<snip>
> +/* BPF_RAND_SEXT_R7 contains 5 instructions, it initializes R7 into a random
> + * negative u32, and sign-extend it into 64-bit.
> + */
> +#define BPF_RAND_SEXT_R7 \
> + BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, \
> + BPF_FUNC_get_prandom_u32), \
> + BPF_MOV64_REG(BPF_REG_7, BPF_REG_0), \
> + BPF_ALU64_IMM(BPF_OR, BPF_REG_7, 0x80000000) \
^~~~ ',' missing
> + BPF_ALU64_IMM(BPF_LSH, BPF_REG_7, 32), \
> + BPF_ALU64_IMM(BPF_ARSH, BPF_REG_7, 32),
^~~~ ',' should be removed
Apology, just found there is a minor fix on testcase that I forget to
commit before generating patch set. One ',' is missing and one ',' should
be removed as described above.
I will correct this in v3 together with other reviews if any.
Regards,
Jiong
next prev parent reply other threads:[~2019-01-23 14:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 13:15 [PATCH bpf-next v2 00/16] bpf: propose new jmp32 instructions Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 01/16] bpf: allocate 0x06 to new eBPF instruction class JMP32 Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 02/16] bpf: refactor verifier min/max code for condition jump Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 03/16] bpf: verifier support JMP32 Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 04/16] bpf: disassembler " Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 05/16] tools: bpftool: teach cfg code about JMP32 Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 06/16] bpf: interpreter support for JMP32 Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 07/16] bpf: JIT blinds support JMP32 Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 08/16] bpf: functional and min/max reasoning unit tests for JMP32 Jiong Wang
2019-01-23 14:29 ` Jiong Wang [this message]
2019-01-21 13:15 ` [PATCH bpf-next v2 09/16] x86_64: bpf: implement jitting of JMP32 Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 10/16] x32: " Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 11/16] arm64: " Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 12/16] arm: " Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 13/16] ppc: " Jiong Wang
2019-01-24 4:58 ` Sandipan Das
2019-01-24 9:53 ` Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 14/16] s390: " Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 15/16] nfp: " Jiong Wang
2019-01-21 13:15 ` [PATCH bpf-next v2 16/16] selftests: bpf: makefile support sub-register code-gen test mode Jiong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imyfa1ma.fsf@netronome.com \
--to=jiong.wang@netronome$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox