From: Vitaly Kuznetsov <vkuznets@redhat•com>
To: David Vrabel <david.vrabel@citrix•com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>, <ptalbert@redhat•com>,
<boris.ostrovsky@oracle•com>, <jgross@suse•com>,
<xen-devel@lists•xenproject.org>
Subject: Re: [PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary
Date: Mon, 19 Sep 2016 12:36:55 +0200 [thread overview]
Message-ID: <87intsxjjs.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <57DFBCB9.1090500@citrix.com> (David Vrabel's message of "Mon, 19 Sep 2016 11:23:53 +0100")
David Vrabel <david.vrabel@citrix•com> writes:
> On 19/09/16 11:22, Vitaly Kuznetsov wrote:
>> David Miller <davem@davemloft•net> writes:
>>
>>> From: Vitaly Kuznetsov <vkuznets@redhat•com>
>>> Date: Fri, 16 Sep 2016 12:59:14 +0200
>>>
>>>> @@ -595,6 +596,19 @@ static int xennet_start_xmit(struct sk_buff *skb, struct net_device *dev)
>>>> offset = offset_in_page(skb->data);
>>>> len = skb_headlen(skb);
>>>>
>>>> + /* The first req should be at least ETH_HLEN size or the packet will be
>>>> + * dropped by netback.
>>>> + */
>>>> + if (unlikely(PAGE_SIZE - offset < ETH_HLEN)) {
>>>> + nskb = skb_copy(skb, GFP_ATOMIC);
>>>> + if (!nskb)
>>>> + goto drop;
>>>> + dev_kfree_skb_any(skb);
>>>> + skb = nskb;
>>>> + page = virt_to_page(skb->data);
>>>> + offset = offset_in_page(skb->data);
>>>> + }
>>>> +
>>>> spin_lock_irqsave(&queue->tx_lock, flags);
>>>
>>> I think you also have to recalculate 'len' in this case too, as
>>> skb_headlen() will definitely be different for nskb.
>>>
>>> In fact, I can't see how this code can work properly without that fix.
>>
>> Thank you for your feedback David,
>>
>> in my testing (even when I tried doing skb_copy() for all skbs
>> unconditionally) skb_headlen(nskb) always equals 'len' so I was under an
>> impression that both 'skb->len' and 'skb->data_len' remain the same when
>> we do skb_copy(). However, in case you think there are cases when
>> headlen changes, I see no problem with re-calculating 'len' as it won't
>> bring any significant performace penalty compared to the already added
>> skb_copy().
>
> I think you can move the len = skb_headlen(skb) after the if, no need to
> recalculate it.
Sorry, I was too fast with sending 'v2' and did the other way
around. I'll do v3.
--
Vitaly
prev parent reply other threads:[~2016-09-19 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 10:59 [PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary Vitaly Kuznetsov
2016-09-19 2:26 ` David Miller
2016-09-19 10:22 ` Vitaly Kuznetsov
2016-09-19 10:23 ` David Vrabel
2016-09-19 10:36 ` Vitaly Kuznetsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87intsxjjs.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat$(echo .)com \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.vrabel@citrix$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ptalbert@redhat$(echo .)com \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox