From: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
To: Wojciech Dubowik <Wojciech.Dubowik@neratec•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org, Wojciech Dubowik <Wojciech.Dubowik@neratec•com>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask
Date: Mon, 30 May 2016 10:17:01 -0400 [thread overview]
Message-ID: <87inxvbpgi.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <1464600944-30782-1-git-send-email-Wojciech.Dubowik@neratec.com>
Hi Wojciech, David,
Wojciech Dubowik <Wojciech.Dubowik@neratec•com> writes:
> Port's vlan table is specified by bit mask and not by number.
> Only 4.4.x kernels are affected.
>
> Signed-off-by: Wojciech Dubowik <Wojciech.Dubowik@neratec•com>
> ---
> drivers/net/dsa/mv88e6xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
> index 2dea39b..3e074d4 100644
> --- a/drivers/net/dsa/mv88e6xxx.c
> +++ b/drivers/net/dsa/mv88e6xxx.c
> @@ -2150,7 +2150,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
> * database, and allow every port to egress frames on all other ports.
> */
> reg = BIT(ps->num_ports) - 1; /* all ports */
> - ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~port);
> + ret = _mv88e6xxx_port_vlan_map_set(ds, port, reg & ~BIT(port));
> if (ret)
> goto abort;
Commit be1faa92e83b ("net: dsa: mv88e6xxx: fix port VLAN maps") in
net/master already fixes this.
But indeed v4.5 contains be1faa92e83b but not v4.4.
Thanks,
Vivien
prev parent reply other threads:[~2016-05-30 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 9:35 [PATCH net] net: dsa: mv88e6xxx: Fix port forwarding mask Wojciech Dubowik
2016-05-30 14:17 ` Vivien Didelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inxvbpgi.fsf@ketchup.mtl.sfl \
--to=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=Wojciech.Dubowik@neratec$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox