public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp•com.au>
To: Ohad Ben-Cohen <ohad@wizery•com>, Erwan Yvin <erwan.yvin@stericsson•com>
Cc: "David S. Miller" <davem@davemloft•net>,
	Rusty Russel <rusty@ruscorp•com.au>,
	Sjur Braendeland <sjur.brandeland@stericsson•com>,
	Linus Walleij <linus.walleij@stericsson•com>,
	virtualization <virtualization@lists•linux-foundation.org>,
	netdev <netdev@vger•kernel.org>
Subject: Re: [PATCHv3 vringh] caif_virtio: Introduce caif over virtio
Date: Mon, 18 Mar 2013 14:15:36 +1030	[thread overview]
Message-ID: <87ip4ps74v.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK=WgbbV6mvYC+KeSKJR+jmrAy3Et5opzzno1_kaicMPdDxNXg@mail.gmail.com>

Ohad Ben-Cohen <ohad@wizery•com> writes:
> Hi Erwan,
>
> On Fri, Mar 15, 2013 at 11:42 AM, Erwan Yvin <erwan.yvin@stericsson•com> wrote:
>> +++ b/drivers/net/caif/caif_virtio.c
...
>> +#include <linux/remoteproc.h>
>
> The driver looks nicely decoupled from remoteproc - do you still need
> remoteproc.h ?

Seems not.

Thanks,
Rusty.

caif_virtio: remove unneeded remoteproc.h

Reported-by: Ohad Ben-Cohen <ohad@wizery•com>
Signed-off-by: Rusty Russell <rusty@rustcorp•com.au>

diff --git a/drivers/net/caif/caif_virtio.c b/drivers/net/caif/caif_virtio.c
index 6a745dd..b1e1205 100644
--- a/drivers/net/caif/caif_virtio.c
+++ b/drivers/net/caif/caif_virtio.c
@@ -15,7 +15,6 @@
 #include <linux/interrupt.h>
 #include <linux/netdevice.h>
 #include <linux/rtnetlink.h>
-#include <linux/remoteproc.h>
 #include <linux/virtio_ids.h>
 #include <linux/virtio_caif.h>
 #include <linux/virtio_ring.h>

  reply	other threads:[~2013-03-18  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  9:42 [PATCHv3 vringh] caif_virtio: Introduce caif over virtio Erwan Yvin
2013-03-17 16:14 ` David Miller
2013-03-18  3:38   ` Rusty Russell
2013-03-17 22:52 ` Ohad Ben-Cohen
2013-03-18  3:45   ` Rusty Russell [this message]
2013-03-18  3:46 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip4ps74v.fsf@rustcorp.com.au \
    --to=rusty@rustcorp$(echo .)com.au \
    --cc=davem@davemloft$(echo .)net \
    --cc=erwan.yvin@stericsson$(echo .)com \
    --cc=linus.walleij@stericsson$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=ohad@wizery$(echo .)com \
    --cc=rusty@ruscorp$(echo .)com.au \
    --cc=sjur.brandeland@stericsson$(echo .)com \
    --cc=virtualization@lists$(echo .)linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox