Subject: Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

From: Peter Korsgaard <[email-masked]>
Date: Mon, 02 Jun 2008 20:32:30 +0200

>>>>> "Bill" == Bill Gatliff <[email-masked]> writes:

 >>> +	/* Initialise tx packet using broadcast destination address */
 >>> +	for (i = 0; i < 6; i++)
 >>> +		pdata->loopback_tx_pkt[i] = (char)0xFF;
 >> 
 >> The cast to char is just noise.

 Bill> Not sure.  What about signed vs. unsigned?

No, because char can be both signed and unsigned. The driver should
rather do a memset(pdate->loopback_tx_pkt, 0xff, ETH_ALEN);

-- 
Bye, Peter Korsgaard