Subject: Re: [PATCH 2/7] dt-bindings: can: mcan: Add ECC functionality to message ram

From: Marc Kleine-Budde <[email-masked]>
Date: Tue, 25 Oct 2022 09:31:36 +0200

You should add the DT people on Cc:
- [email-masked]
- Rob Herring <[email-masked]>

On 21.10.2022 15:28:28, Vivek Yadav wrote:
> Whenever the data is transferred or stored on message ram, there are
> inherent risks of it being lost or corruption known as single-bit errors.
> 
> ECC constantly scans data as it is processed to the message ram, using a
> method known as parity checking and raise the error signals for corruption.
> 
> Add error correction code config property to enable/disable the
> error correction code (ECC) functionality for Message RAM used to create
> valid ECC checksums.
> 
> Signed-off-by: Chandrasekar R <[email-masked]>
> Signed-off-by: Vivek Yadav <[email-masked]>
> ---
>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index 26aa0830eea1..0ba3691863d7 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -50,6 +50,10 @@ properties:
>        - const: hclk
>        - const: cclk
>  
> +  mram-ecc-cfg:

This probably needs a prefix and a "$ref: /schemas/types.yaml#/definitions/phandle".

> +    items:
> +      - description: M_CAN ecc registers map with configuration register offset
> +
>    bosch,mram-cfg:
>      description: |
>        Message RAM configuration data.
> -- 
> 2.17.1
> 
> 

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |