From: Kalle Valo <kvalo@kernel•org>
To: Larry Finger <Larry.Finger@lwfinger•net>
Cc: "Benjamin Stürz" <benni@stuerz•xyz>,
andrew@lunn•ch, sebastian.hesselbarth@gmail•com,
gregory.clement@bootlin•com, linux@armlinux•org.uk,
linux@simtec•co.uk, krzk@kernel•org, alim.akhtar@samsung•com,
tglx@linutronix•de, mingo@redhat•com, bp@alien8•de,
dave.hansen@linux•intel.com, hpa@zytor•com,
robert.moore@intel•com, rafael.j.wysocki@intel•com,
lenb@kernel•org, 3chas3@gmail•com, laforge@gnumonks•org,
arnd@arndb•de, gregkh@linuxfoundation•org, mchehab@kernel•org,
tony.luck@intel•com, james.morse@arm•com, rric@kernel•org,
linus.walleij@linaro•org, brgl@bgdev•pl,
mike.marciniszyn@cornelisnetworks•com,
dennis.dalessandro@cornelisnetworks•com, jgg@ziepe•ca,
pali@kernel•org, dmitry.torokhov@gmail•com, isdn@linux-pingi•de,
benh@kernel•crashing.org, fbarrat@linux•ibm.com,
ajd@linux•ibm.com, davem@davemloft•net, kuba@kernel•org,
pabeni@redhat•com, nico@fluxnic•net, loic.poulain@linaro•org,
pkshih@realtek•com, bhelgaas@google•com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
linux-ia64@vger•kernel.org, linux-acpi@vger•kernel.org,
devel@acpica•org, linux-atm-general@lists•sourceforge.net,
netdev@vger•kernel.org, linux-edac@vger•kernel.org,
linux-gpio@vger•kernel.org, linux-rdma@vger•kernel.org,
linux-input@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-media@vger•kernel.org, wcn36xx@lists•infradead.org,
linux-wireless@vger•kernel.org, linux-pci@vger•kernel.org
Subject: Re: [PATCH 21/22] rtw89: Replace comments with C99 initializers
Date: Mon, 28 Mar 2022 12:28:30 +0300 [thread overview]
Message-ID: <87k0cezarl.fsf@kernel.org> (raw)
In-Reply-To: <f7bb9164-2f66-8985-5771-5f31ee5740b7@lwfinger.net> (Larry Finger's message of "Sat, 26 Mar 2022 13:55:33 -0500")
Larry Finger <Larry.Finger@lwfinger•net> writes:
> On 3/26/22 11:59, Benjamin Stürz wrote:
>> This replaces comments with C99's designated
>> initializers because the kernel supports them now.
>>
>> Signed-off-by: Benjamin Stürz <benni@stuerz•xyz>
>> ---
>> drivers/net/wireless/realtek/rtw89/coex.c | 40 +++++++++++------------
>> 1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtw89/coex.c b/drivers/net/wireless/realtek/rtw89/coex.c
>> index 684583955511..3c83a0bfb120 100644
>> --- a/drivers/net/wireless/realtek/rtw89/coex.c
>> +++ b/drivers/net/wireless/realtek/rtw89/coex.c
>> @@ -97,26 +97,26 @@ static const struct rtw89_btc_fbtc_slot s_def[] = {
>> };
>> static const u32 cxtbl[] = {
>> - 0xffffffff, /* 0 */
>> - 0xaaaaaaaa, /* 1 */
>> - 0x55555555, /* 2 */
>> - 0x66555555, /* 3 */
>> - 0x66556655, /* 4 */
>> - 0x5a5a5a5a, /* 5 */
>> - 0x5a5a5aaa, /* 6 */
>> - 0xaa5a5a5a, /* 7 */
>> - 0x6a5a5a5a, /* 8 */
>> - 0x6a5a5aaa, /* 9 */
>> - 0x6a5a6a5a, /* 10 */
>> - 0x6a5a6aaa, /* 11 */
>> - 0x6afa5afa, /* 12 */
>> - 0xaaaa5aaa, /* 13 */
>> - 0xaaffffaa, /* 14 */
>> - 0xaa5555aa, /* 15 */
>> - 0xfafafafa, /* 16 */
>> - 0xffffddff, /* 17 */
>> - 0xdaffdaff, /* 18 */
>> - 0xfafadafa /* 19 */
>> + [0] = 0xffffffff,
>> + [1] = 0xaaaaaaaa,
>> + [2] = 0x55555555,
>> + [3] = 0x66555555,
>> + [4] = 0x66556655,
>> + [5] = 0x5a5a5a5a,
>> + [6] = 0x5a5a5aaa,
>> + [7] = 0xaa5a5a5a,
>> + [8] = 0x6a5a5a5a,
>> + [9] = 0x6a5a5aaa,
>> + [10] = 0x6a5a6a5a,
>> + [11] = 0x6a5a6aaa,
>> + [12] = 0x6afa5afa,
>> + [13] = 0xaaaa5aaa,
>> + [14] = 0xaaffffaa,
>> + [15] = 0xaa5555aa,
>> + [16] = 0xfafafafa,
>> + [17] = 0xffffddff,
>> + [18] = 0xdaffdaff,
>> + [19] = 0xfafadafa
>> };
>> struct rtw89_btc_btf_tlv {
>
>
> Is this change really necessary? Yes, the entries must be ordered;
> however, the comment carries that information at very few extra
> characters. To me, this patch looks like unneeded source churn.
One small benefit I see is to avoid the comment index being wrong and
there would be no way to catch that. But otherwise I don't have any
opinion about this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-03-28 9:28 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 16:58 [PATCH 01/22] orion5x: Replace comments with C99 initializers Benjamin Stürz
2022-03-26 16:58 ` [PATCH 02/22] s3c: " Benjamin Stürz
2022-03-26 19:44 ` Joe Perches
2022-03-28 13:37 ` Daniel Thompson
2022-03-26 16:58 ` [PATCH 03/22] ia64: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 04/22] x86: " Benjamin Stürz
2022-03-28 23:08 ` Thomas Gleixner
2022-03-26 16:58 ` [PATCH 05/22] acpica: " Benjamin Stürz
2022-03-27 19:59 ` Andy Shevchenko
2022-03-31 19:27 ` Moore, Robert
2022-04-01 5:09 ` Christoph Hellwig
2022-04-01 5:10 ` Christoph Hellwig
2022-03-28 12:33 ` Rafael J. Wysocki
2022-03-26 16:58 ` [PATCH 06/22] idt77252: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 07/22] cm4000: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 08/22] i5100: " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 09/22] gpio-winbond: Use " Benjamin Stürz
2022-03-27 12:03 ` Linus Walleij
2022-03-29 12:30 ` Bartosz Golaszewski
2022-03-26 16:58 ` [PATCH 10/22] hfi1: Replace comments with " Benjamin Stürz
2022-03-26 16:58 ` [PATCH 11/22] rdmavt: " Benjamin Stürz
2022-03-27 7:04 ` Leon Romanovsky
2022-03-31 17:41 ` Dennis Dalessandro
2022-03-26 16:58 ` [PATCH 12/22] alps: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 13/22] capi: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 14/22] mISDN: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 15/22] macintosh: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 16/22] dvb-usb: " Benjamin Stürz
2022-03-26 18:24 ` Mauro Carvalho Chehab
2022-03-26 18:27 ` Mauro Carvalho Chehab
2022-03-26 19:51 ` Joe Perches
2022-03-26 20:11 ` Larry Finger
2022-03-26 21:08 ` Mauro Carvalho Chehab
2022-03-26 16:59 ` [PATCH 17/22] cxl: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 18/22] smsc: " Benjamin Stürz
2022-03-26 16:59 ` [PATCH 19/22] wnc36xx: " Benjamin Stürz
2022-03-28 16:17 ` Jeff Johnson
2022-03-28 18:38 ` [PATCH 19/22 v2] wcn36xx: Improve readability of wcn36xx_caps_name Benjamin Stürz
2022-03-28 20:23 ` Jeff Johnson
2022-03-30 7:05 ` Kalle Valo
2022-03-30 8:19 ` Kalle Valo
2022-03-26 16:59 ` [PATCH 20/22] wireless: Replace comments with C99 initializers Benjamin Stürz
2022-03-28 12:06 ` Kalle Valo
2022-03-28 18:21 ` [PATCH 20/22 v2] ray_cs: " Benjamin Stürz
2022-03-28 19:23 ` Joe Perches
2022-03-28 19:54 ` [PATCH 20/22 v3] ray_cs: Improve card_status[] Benjamin Stürz
2022-04-06 11:31 ` Kalle Valo
2022-03-26 16:59 ` [PATCH 21/22] rtw89: Replace comments with C99 initializers Benjamin Stürz
2022-03-26 18:55 ` Larry Finger
2022-03-28 9:28 ` Kalle Valo [this message]
2022-03-28 12:21 ` David Laight
2022-03-26 16:59 ` [PATCH 22/22] pci: " Benjamin Stürz
2022-03-26 18:20 ` [PATCH 01/22] orion5x: " Mauro Carvalho Chehab
2022-03-26 19:23 ` Arnd Bergmann
2022-03-28 13:19 ` Segher Boessenkool
2022-03-27 12:46 ` [PATCH 00/22] " Benjamin Stürz
2022-03-28 9:33 ` Kalle Valo
2022-03-28 11:51 ` Benjamin Stürz
2022-03-28 12:31 ` Kalle Valo
2022-03-28 20:20 ` Jakub Kicinski
2022-03-28 13:47 ` Daniel Thompson
2022-03-28 13:17 ` [PATCH 01/22] orion5x: " Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0cezarl.fsf@kernel.org \
--to=kvalo@kernel$(echo .)org \
--cc=3chas3@gmail$(echo .)com \
--cc=Larry.Finger@lwfinger$(echo .)net \
--cc=ajd@linux$(echo .)ibm.com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=benni@stuerz$(echo .)xyz \
--cc=bhelgaas@google$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brgl@bgdev$(echo .)pl \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dennis.dalessandro@cornelisnetworks$(echo .)com \
--cc=devel@acpica$(echo .)org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=fbarrat@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=isdn@linux-pingi$(echo .)de \
--cc=james.morse@arm$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=krzk@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=laforge@gnumonks$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-atm-general@lists$(echo .)sourceforge.net \
--cc=linux-edac@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@simtec$(echo .)co.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=loic.poulain@linaro$(echo .)org \
--cc=mchehab@kernel$(echo .)org \
--cc=mike.marciniszyn@cornelisnetworks$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nico@fluxnic$(echo .)net \
--cc=pabeni@redhat$(echo .)com \
--cc=pali@kernel$(echo .)org \
--cc=pkshih@realtek$(echo .)com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=robert.moore@intel$(echo .)com \
--cc=rric@kernel$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=wcn36xx@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox